thr3ads.net - LARTC - [PATCH] mark in u32 [Jan 2005]

If this information is useful, please help other people find it:
Share via:

Catalin(ux aka Dino) BOIE

2005-Jan-05 10:05 UTC

[PATCH] mark in u32

Hello, Stephen, List!

Attached is the patch for iproute2 to add the possibility to use fwmark in 
u32 filters.
The kernel part was included in 2.6.10.

Please apply!
Thank you!

For more info:
- Kernel patch (not needed for 2.6.10): 
http://kernel.umbrella.ro/net/mark_in_u32/net-match-nfmark-in-u32.patch

- Examples:
http://kernel.umbrella.ro/net/mark_in_u32/examples.txt

---
Catalin(ux aka Dino) BOIE
catab at deuroconsult.ro
http://kernel.umbrella.ro/

Andy Furniss

2005-Jan-05 14:59 UTC

head link

Re: [PATCH] mark in u32

Catalin(ux aka Dino) BOIE wrote:> Hello, Stephen, List!
> 
> Attached is the patch for iproute2 to add the possibility to use fwmark 
> in u32 filters.
> The kernel part was included in 2.6.10.
> 
> Please apply!
> Thank you!
> 
> For more info:
> - Kernel patch (not needed for 2.6.10): 
> http://kernel.umbrella.ro/net/mark_in_u32/net-match-nfmark-in-u32.patch
> 
> - Examples:
> http://kernel.umbrella.ro/net/mark_in_u32/examples.txt
> 
> ---
> Catalin(ux aka Dino) BOIE
> catab at deuroconsult.ro
> http://kernel.umbrella.ro/
That looks handy :-) Do you know why fw mark doesn''t work with policers
in 2.6 (assuming it''s not just me)

To stephen - I may be wrong here but in the readme it says that default 
kernel include is /usr/src/linux/include but if I grep for 
KERNEL_INCLUDE I see :-

./Makefile:KERNEL_INCLUDE:=/usr/include
./Makefile:CFLAGS = $(CCOPTS) -I$(KERNEL_INCLUDE) -I../include $(DEFINES)
./Makefile:     ./configure $(KERNEL_INCLUDE)
./README:KERNEL_INCLUDE should point to correct linux kernel include 
directory.


ISTR having to mess about a bit last time when applying esfq patch to 
get it to work.

Andy.

_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Thomas Graf

2005-Jan-05 15:10 UTC

head link

Re: [PATCH] mark in u32

> That looks handy :-) Do you know why fw mark doesn''t work with
policers
> in 2.6 (assuming it''s not just me)
Be prepared to see it removed again in favour of the meta extended
match. Don''t rely too much on it.

Regarding fw, what exactly is not working? fw doesn''t handle police
results properly, the patchset at http://people.suug.ch/~tgr/patches/pending/
fixes this. Given its another issue, I would be curious to know what
exactly is not working.
> ISTR having to mess about a bit last time when applying esfq patch to 
> get it to work.
Would you guys like to see esfq included in mainline?
_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Andy Furniss

2005-Jan-05 15:25 UTC

head link

Re: [PATCH] mark in u32

Thomas Graf wrote:>>That looks handy :-) Do you know why fw mark doesn''t work with
policers
>>in 2.6 (assuming it''s not just me)
> 
> 
> Be prepared to see it removed again in favour of the meta extended
> match. Don''t rely too much on it.
I searched a bit around meta data recently but couldn''t find much - do 
you have any links?
> 
> Regarding fw, what exactly is not working? fw doesn''t handle
police
> results properly, the patchset at
http://people.suug.ch/~tgr/patches/pending/
> fixes this. Given its another issue, I would be curious to know what
> exactly is not working.
It was for a test I did, though I notice some of the diffserv examples 
use it aswell (albeit with ipchains).

http://marc.theaimsgroup.com/?l=lartc&m=110122532022827&w=2
> 
> 
>>ISTR having to mess about a bit last time when applying esfq patch to 
>>get it to work.
> 
> 
> Would you guys like to see esfq included in mainline?
> 
Yea - that would be great :-)

Andy.

_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Thomas Graf

2005-Jan-05 15:52 UTC

head link

Re: [PATCH] mark in u32

* Andy Furniss <41DC06D8.70301@dsl.pipex.com> 2005-01-05
15:25> Thomas Graf wrote:
> >>That looks handy :-) Do you know why fw mark doesn''t work
with policers
> >>in 2.6 (assuming it''s not just me)
> >
> >
> >Be prepared to see it removed again in favour of the meta extended
> >match. Don''t rely too much on it.
> 
> I searched a bit around meta data recently but couldn''t find much
- do
> you have any links?
http://oss.sgi.com/archives/netdev/2004-12/msg00767.html
http://oss.sgi.com/archives/netdev/2005-01/msg00028.html
> http://marc.theaimsgroup.com/?l=lartc&m=110122532022827&w=2
Do you see the police/action stats being updated? i.e. does
the matching itself work?

Ingress qdisc reads from prerouting hook as well, might be
a priority issue.
_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Andy Furniss

2005-Jan-05 16:40 UTC

head link

Re: [PATCH] mark in u32

Thomas Graf wrote:> * Andy Furniss <41DC06D8.70301@dsl.pipex.com> 2005-01-05 15:25
> 
>>Thomas Graf wrote:
>>
>>>>That looks handy :-) Do you know why fw mark doesn''t
work with policers
>>>>in 2.6 (assuming it''s not just me)
>>>
>>>
>>>Be prepared to see it removed again in favour of the meta extended
>>>match. Don''t rely too much on it.
>>
>>I searched a bit around meta data recently but couldn''t find
much - do
>>you have any links?
> 
> 
> http://oss.sgi.com/archives/netdev/2004-12/msg00767.html
> http://oss.sgi.com/archives/netdev/2005-01/msg00028.html
Thanks.
> 
> 
>>http://marc.theaimsgroup.com/?l=lartc&m=110122532022827&w=2
> 
> 
> Do you see the police/action stats being updated? i.e. does
> the matching itself work?
 From memory yes - counters showed OK on iptables and tc -s qdisc ls dev 
eth0 just no drops

I''ll repeat tonight to be sure.

Andy.
> 
> Ingress qdisc reads from prerouting hook as well, might be
> a priority issue.
> _______________________________________________
> LARTC mailing list / LARTC@mailman.ds9a.nl
> http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/
> 

_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Stephen Hemminger

2005-Jan-05 23:44 UTC

head link

Re: [PATCH] mark in u32

On Wed, 05 Jan 2005 14:59:44 +0000
Andy Furniss <andy.furniss@dsl.pipex.com> wrote:
> Catalin(ux aka Dino) BOIE wrote:
> > Hello, Stephen, List!
> > 
> > Attached is the patch for iproute2 to add the possibility to use
fwmark
> > in u32 filters.
> > The kernel part was included in 2.6.10.
> > 
> > Please apply!
> > Thank you!
> > 
> > For more info:
> > - Kernel patch (not needed for 2.6.10): 
> >
http://kernel.umbrella.ro/net/mark_in_u32/net-match-nfmark-in-u32.patch
> > 
> > - Examples:
> > http://kernel.umbrella.ro/net/mark_in_u32/examples.txt
> > 
> > ---
> > Catalin(ux aka Dino) BOIE
> > catab at deuroconsult.ro
> > http://kernel.umbrella.ro/
> 
> That looks handy :-) Do you know why fw mark doesn''t work with
policers
> in 2.6 (assuming it''s not just me)
> 
> To stephen - I may be wrong here but in the readme it says that default 
> kernel include is /usr/src/linux/include but if I grep for 
> KERNEL_INCLUDE I see :-
> 
> ./Makefile:KERNEL_INCLUDE:=/usr/include
> ./Makefile:CFLAGS = $(CCOPTS) -I$(KERNEL_INCLUDE) -I../include $(DEFINES)
> ./Makefile:     ./configure $(KERNEL_INCLUDE)
> ./README:KERNEL_INCLUDE should point to correct linux kernel include 
> directory.
I changed away from Alexey''s old KERNEL_INCLUDE, because it was
necessary
for the package to be able to be compiled without depending on the kernel
header files. There were cases where new features needed to be compiled on
old systems where the definition was missing.  Think about building current
iproute2 util''s with 2.4.20 includes.

The current solution (though less than ideal) was to put stripped down
version of the routing specific includes into the iproute2 package.
_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Andy Furniss

2005-Jan-06 08:53 UTC

head link

Re: [PATCH] mark in u32

Stephen Hemminger wrote:> On Wed, 05 Jan 2005 14:59:44 +0000
> Andy Furniss <andy.furniss@dsl.pipex.com> wrote:
> 
> 
>>Catalin(ux aka Dino) BOIE wrote:
>>
>>>Hello, Stephen, List!
>>>
>>>Attached is the patch for iproute2 to add the possibility to use
fwmark
>>>in u32 filters.
>>>The kernel part was included in 2.6.10.
>>>
>>>Please apply!
>>>Thank you!
>>>
>>>For more info:
>>>- Kernel patch (not needed for 2.6.10): 
>>>http://kernel.umbrella.ro/net/mark_in_u32/net-match-nfmark-in-u32.patch
>>>
>>>- Examples:
>>>http://kernel.umbrella.ro/net/mark_in_u32/examples.txt
>>>
>>>---
>>>Catalin(ux aka Dino) BOIE
>>>catab at deuroconsult.ro
>>>http://kernel.umbrella.ro/
>>
>>That looks handy :-) Do you know why fw mark doesn''t work with
policers
>>in 2.6 (assuming it''s not just me)
>>
>>To stephen - I may be wrong here but in the readme it says that default 
>>kernel include is /usr/src/linux/include but if I grep for 
>>KERNEL_INCLUDE I see :-
>>
>>./Makefile:KERNEL_INCLUDE:=/usr/include
>>./Makefile:CFLAGS = $(CCOPTS) -I$(KERNEL_INCLUDE) -I../include
$(DEFINES)
>>./Makefile:     ./configure $(KERNEL_INCLUDE)
>>./README:KERNEL_INCLUDE should point to correct linux kernel include 
>>directory.
> 
> 
> I changed away from Alexey''s old KERNEL_INCLUDE, because it was
necessary
> for the package to be able to be compiled without depending on the kernel
> header files. There were cases where new features needed to be compiled on
> old systems where the definition was missing.  Think about building current
> iproute2 util''s with 2.4.20 includes.
> 
> The current solution (though less than ideal) was to put stripped down
> version of the routing specific includes into the iproute2 package.
> 
Ahh I see, thanks for the explanation.

Andy.


_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Andy Furniss

2005-Jan-06 09:00 UTC

head link

Re: [PATCH] mark in u32

Andy Furniss wrote:> Thomas Graf wrote:
>>
>> Do you see the police/action stats being updated? i.e. does
>> the matching itself work?
> 
> 
>  From memory yes - counters showed OK on iptables and tc -s qdisc ls dev 
> eth0 just no drops
> 
> I''ll repeat tonight to be sure.
I retried with a vanilla 2.6.10 + iptables 1.2.11 on a different box and 
it is the same.

The only difference between working and not working cases when using tc 
-s qdisc ls dev eth0 is the drops count. The stats are OK apart from that.

Andy.


_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Thomas Graf

2005-Jan-06 09:50 UTC

head link

Re: [PATCH] mark in u32

* Andy Furniss <41DCFE27.4030704@dsl.pipex.com> 2005-01-06
09:00> I retried with a vanilla 2.6.10 + iptables 1.2.11 on a different box and 
> it is the same.
2 options:
 1) get latest -bk snapshot and apply
http://people.suug.ch/~tgr/patches/pending/
    The patchset fixes a lot of small issues, adds action capabilities to
    all classifiers, and extends tcindex and route classifier to be changeable
    during runtime. If problem remains, goto to 2.
 2) Provided detailed information about how your police configuration
    looks like, wehther you are using CONFIG_NET_CLS_ACT,  etc. so I can fix it.
> The only difference between working and not working cases when using tc 
> -s qdisc ls dev eth0 is the drops count. The stats are OK apart from that.
And it is definitely classifier specific to fw? 
_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Andy Furniss

2005-Jan-06 13:27 UTC

head link

Re: [PATCH] mark in u32

Thomas Graf wrote:> * Andy Furniss <41DCFE27.4030704@dsl.pipex.com> 2005-01-06 09:00
> 
>>I retried with a vanilla 2.6.10 + iptables 1.2.11 on a different box and
>>it is the same.
> 
> 
> 2 options:
>  1) get latest -bk snapshot and apply
http://people.suug.ch/~tgr/patches/pending/
>     The patchset fixes a lot of small issues, adds action capabilities to
>     all classifiers, and extends tcindex and route classifier to be
changeable
>     during runtime. If problem remains, goto to 2.
Could take some time - I don''t have bitkeeper and will have to find
some
  disk space. I''ll try soon(ish).

>  2) Provided detailed information about how your police configuration
>     looks like, wehther you are using CONFIG_NET_CLS_ACT,  etc. so I can
fix it.
I just tried some variations - but get an error - I am using new tc and get

RTNETLINK answers: Invalid argument
We have an error talking to the kernel

  with the last 2 - see below.
> 
> 
>>The only difference between working and not working cases when using tc 
>>-s qdisc ls dev eth0 is the drops count. The stats are OK apart from
that.
> 
> 
> And it is definitely classifier specific to fw? 
I don''t know what should I test with :-)

tc filter add dev eth0 parent ffff: protocol ip prio 1 u32 match ip src 
0.0.0.0/0 police rate 100kbit burst 10k drop flowid :1

Works OK.

tc filter add dev eth0 parent ffff: protocol 6 prio 1 u32 match ip src 
0.0.0.0/0 police rate 100kbit burst 10k drop flowid :1

Doesn''t work even on 2.4 that fw test works on.

[andy@amd ~]$ grep NET_CLS /boot/config-lfs-5.1-2.4.26
CONFIG_NET_CLS=y
CONFIG_NET_CLS_TCINDEX=m
CONFIG_NET_CLS_ROUTE4=m
CONFIG_NET_CLS_ROUTE=y
CONFIG_NET_CLS_FW=m
CONFIG_NET_CLS_U32=m
CONFIG_NET_CLS_RSVP=m
CONFIG_NET_CLS_RSVP6=m
CONFIG_NET_CLS_POLICE=y

Is the 2.4 that''s OK.

[andy@amd ~]$ grep NET_CLS /boot/config-2.6.10
CONFIG_NET_CLS=y
CONFIG_NET_CLS_TCINDEX=m
CONFIG_NET_CLS_ROUTE4=m
CONFIG_NET_CLS_ROUTE=y
CONFIG_NET_CLS_FW=m
CONFIG_NET_CLS_U32=m
# CONFIG_NET_CLS_IND is not set
CONFIG_NET_CLS_RSVP=m
CONFIG_NET_CLS_RSVP6=m
CONFIG_NET_CLS_ACT=y

Is the fail on fw but work on ip src 0.0.0.0/0

Below are the ones that throw an error when I tc filter add (anything)

tc qdisc add dev eth0 handle ffff: ingress is OK

[andy@amd ~]$ grep NET_CLS /boot/config-2.6.10-2
CONFIG_NET_CLS=y
CONFIG_NET_CLS_TCINDEX=m
CONFIG_NET_CLS_ROUTE4=m
CONFIG_NET_CLS_ROUTE=y
CONFIG_NET_CLS_FW=m
CONFIG_NET_CLS_U32=m
# CONFIG_NET_CLS_IND is not set
CONFIG_NET_CLS_RSVP=m
CONFIG_NET_CLS_RSVP6=m
# CONFIG_NET_CLS_ACT is not set
CONFIG_NET_CLS_POLICE=y

[andy@amd ~]$ grep NET_CLS /boot/config-2.6.10-3
CONFIG_NET_CLS=y
CONFIG_NET_CLS_TCINDEX=m
CONFIG_NET_CLS_ROUTE4=m
CONFIG_NET_CLS_ROUTE=y
CONFIG_NET_CLS_FW=m
CONFIG_NET_CLS_U32=m
# CONFIG_NET_CLS_IND is not set
CONFIG_NET_CLS_RSVP=m
CONFIG_NET_CLS_RSVP6=m
CONFIG_NET_CLS_ACT=y
CONFIG_NET_CLS_POLICE=y

_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Thomas Graf

2005-Jan-06 16:45 UTC

head link

Re: [PATCH] mark in u32

* Andy Furniss <41DD3CBC.1010108@dsl.pipex.com> 2005-01-06
13:27> Thomas Graf wrote:
> >* Andy Furniss <41DCFE27.4030704@dsl.pipex.com> 2005-01-06 09:00
> >
> >>I retried with a vanilla 2.6.10 + iptables 1.2.11 on a different
box and
> >>it is the same.
> >
> >
> >2 options:
> > 1) get latest -bk snapshot and apply 
> > http://people.suug.ch/~tgr/patches/pending/
> >    The patchset fixes a lot of small issues, adds action capabilities
to
> >    all classifiers, and extends tcindex and route classifier to be 
> >    changeable
> >    during runtime. If problem remains, goto to 2.
> 
> Could take some time - I don''t have bitkeeper and will have to
find some
>  disk space. I''ll try soon(ish).
You don''t need bitkeeper, just download the .10 and the latest patch to
get to -bk8 then apply my patches.
> tc filter add dev eth0 parent ffff: protocol ip prio 1 u32 match ip src 
> 0.0.0.0/0 police rate 100kbit burst 10k drop flowid :1
> 
> Works OK.
> 
> tc filter add dev eth0 parent ffff: protocol 6 prio 1 u32 match ip src 
> 0.0.0.0/0 police rate 100kbit burst 10k drop flowid :1
Use a different prio, one that is not yet occupied by a protocol/kind
tuple.
> [andy@amd ~]$ grep NET_CLS /boot/config-2.6.10
> CONFIG_NET_CLS=y
> CONFIG_NET_CLS_TCINDEX=m
> CONFIG_NET_CLS_ROUTE4=m
> CONFIG_NET_CLS_ROUTE=y
> CONFIG_NET_CLS_FW=m
> CONFIG_NET_CLS_U32=m
> # CONFIG_NET_CLS_IND is not set
> CONFIG_NET_CLS_RSVP=m
> CONFIG_NET_CLS_RSVP6=m
> CONFIG_NET_CLS_ACT=y
CONFIG_NET_CLS_ACT_POLICE?
> [andy@amd ~]$ grep NET_CLS /boot/config-2.6.10-2
> CONFIG_NET_CLS=y
> CONFIG_NET_CLS_TCINDEX=m
> CONFIG_NET_CLS_ROUTE4=m
> CONFIG_NET_CLS_ROUTE=y
> CONFIG_NET_CLS_FW=m
> CONFIG_NET_CLS_U32=m
> # CONFIG_NET_CLS_IND is not set
> CONFIG_NET_CLS_RSVP=m
> CONFIG_NET_CLS_RSVP6=m
> # CONFIG_NET_CLS_ACT is not set
> CONFIG_NET_CLS_POLICE=y
> 
> [andy@amd ~]$ grep NET_CLS /boot/config-2.6.10-3
> CONFIG_NET_CLS=y
> CONFIG_NET_CLS_TCINDEX=m
> CONFIG_NET_CLS_ROUTE4=m
> CONFIG_NET_CLS_ROUTE=y
> CONFIG_NET_CLS_FW=m
> CONFIG_NET_CLS_U32=m
> # CONFIG_NET_CLS_IND is not set
> CONFIG_NET_CLS_RSVP=m
> CONFIG_NET_CLS_RSVP6=m
Gonna look at this, do you preload the modules and if not, do you have
the correct modutils version etc?
> CONFIG_NET_CLS_ACT=y
> CONFIG_NET_CLS_POLICE=y
This is not valid and has been fixed in bk.
_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Andy Furniss

2005-Jan-06 23:23 UTC

head link

Re: [PATCH] mark in u32

Thomas Graf wrote:
> You don''t need bitkeeper, just download the .10 and the latest
patch to
> get to -bk8 then apply my patches.
> 
> 
>>tc filter add dev eth0 parent ffff: protocol ip prio 1 u32 match ip src 
>>0.0.0.0/0 police rate 100kbit burst 10k drop flowid :1
>>
>>Works OK.
>>
>>tc filter add dev eth0 parent ffff: protocol 6 prio 1 u32 match ip src 
>>0.0.0.0/0 police rate 100kbit burst 10k drop flowid :1
> 
> 
> Use a different prio, one that is not yet occupied by a protocol/kind
> tuple.
OK will try.
> 
> CONFIG_NET_CLS_ACT_POLICE?
I can''t find it! neither can grep .config

This could be it. I just deleted everything to do with 2.6.10, booted 
into 2.6.9 to start again with fresh 2.6.10 source tree.

When I do make menuconfig I notice it uses defaults from 
/boot/config-2.6.9 (I will remove and try again later).

So maybe this is why I can''t find CONFIG_NET_CLS_ACT_POLICE ?
>>[andy@amd ~]$ grep NET_CLS /boot/config-2.6.10-3
>>CONFIG_NET_CLS=y
>>CONFIG_NET_CLS_TCINDEX=m
>>CONFIG_NET_CLS_ROUTE4=m
>>CONFIG_NET_CLS_ROUTE=y
>>CONFIG_NET_CLS_FW=m
>>CONFIG_NET_CLS_U32=m
>># CONFIG_NET_CLS_IND is not set
>>CONFIG_NET_CLS_RSVP=m
>>CONFIG_NET_CLS_RSVP6=m
> 
> 
> Gonna look at this, do you preload the modules and if not, do you have
> the correct modutils version etc?
Sorry - don''t waste your time - I goofed my bzImage / GRUB naming so I 
was loading the first one I did all along.

Andy.

_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Thomas Graf

2005-Jan-06 23:25 UTC

head link

Re: [PATCH] mark in u32

* Andy Furniss <41DDC858.6010908@dsl.pipex.com> 2005-01-06
23:23> >CONFIG_NET_CLS_ACT_POLICE?
> 
> I can''t find it! neither can grep .config
Sorry, it''s called CONFIG_NET_ACT_POLICE
_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Andy Furniss

2005-Jan-06 23:35 UTC

head link

Re: [PATCH] mark in u32

Thomas Graf wrote:> * Andy Furniss <41DDC858.6010908@dsl.pipex.com> 2005-01-06 23:23
> 
>>>CONFIG_NET_CLS_ACT_POLICE?
>>
>>I can''t find it! neither can grep .config
> 
> 
> Sorry, it''s called CONFIG_NET_ACT_POLICE
> 
OK - will be booting back into LFS to try soon.

Andy.


_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Andy Furniss

2005-Jan-07 02:45 UTC

head link

Re: [PATCH] mark in u32

Andy Furniss wrote:> Thomas Graf wrote:
> 
>> * Andy Furniss <41DDC858.6010908@dsl.pipex.com> 2005-01-06 23:23
>>
>>>> CONFIG_NET_CLS_ACT_POLICE?
>>>
>>>
>>> I can''t find it! neither can grep .config
>>
>>
>>
>> Sorry, it''s called CONFIG_NET_ACT_POLICE
>>
> 
> OK - will be booting back into LFS to try soon.
Still no luck - I got build errors with bk8 (same type as below in fbdev 
IIRC) so tried bk9 and got error below. I''ve seen that before with 
2.95.3  (though it was mandrakes not LFS - had to move some vars up to 
top to get Ed Wildgooses dsl patch to compile IIRC) so I tried bk8 with 
gcc 3.3 and it built OK, but still no luck + my usb intelli mouse
didn''t
work.

I tried the prio change on a 2.4 but it makes no difference.

I have CONFIG_NET_ACT_POLICE in all my configs and police auto loads OK 
on 2.6.9 (haven''t checked others yet)- the 2.6.10-bk8 didn''t
autoload it
though, but modprobe first didn''t help.

Probably lots more to try/check but it''s getting late :-)

Does my initial test case work OK for you guys ?

http://marc.theaimsgroup.com/?l=lartc&m=110122532022827&w=2

The build error -

   CC      net/sched/sch_generic.o
   CC      net/sched/sch_api.o
   CC      net/sched/sch_fifo.o
   CC      net/sched/cls_api.o
net/sched/cls_api.c: In function `tcf_exts_validate'':
net/sched/cls_api.c:467: parse error before `int''
net/sched/cls_api.c:471: `act'' undeclared (first use in this function)
net/sched/cls_api.c:471: (Each undeclared identifier is reported only once
net/sched/cls_api.c:471: for each function it appears in.)
net/sched/cls_api.c:472: `err'' undeclared (first use in this function)
make[2]: *** [net/sched/cls_api.o] Error 1
make[1]: *** [net/sched] Error 2
make: *** [net] Error 2

Andy.




_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Andy Furniss

2005-Jan-07 10:29 UTC

head link

Re: [PATCH] mark in u32

Andy Furniss wrote:
> my usb intelli mouse didn''t 
> work.
> 
  the 2.6.10-bk8 didn''t autoload it> though, 
Of course putting -bk8 on my /boot/System.map-2.6.10 will fix that ...

Will try more tonight.

Andy.


_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Andy Furniss

2005-Jan-08 02:34 UTC

head link

Re: [PATCH] mark in u32

Andy Furniss wrote:> Andy Furniss wrote:
> 
>> my usb intelli mouse didn''t work.
>>
>  the 2.6.10-bk8 didn''t autoload it
> 
>> though, 
> 
> 
> Of course putting -bk8 on my /boot/System.map-2.6.10 will fix that ...
It didn''t :-(  but I tried more on 2.6.9 and found a u32 that works -

tc filter add dev eth0 parent ffff: prio 1 protocol ip u32 match ip 
protocol 6 0xff police rate 100kbit burst 10k drop flowid :1

is OK so maybe it is just the fw case that fails.

Andy.


_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

gypsy

2005-Jan-08 04:14 UTC

head link

Re: [PATCH] mark in u32

Thomas Graf wrote:> 
> Would you guys like to see esfq included in mainline?
YES!!

gypsy
_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

gypsy

2005-Jan-08 04:58 UTC

head link

Re: [PATCH] mark in u32

gypsy wrote:> 
> Thomas Graf wrote:
> >
> 
> > Would you guys like to see esfq included in mainline?
> 
> YES!!
> 
> gypsy
Thomas,

Let me rephrase that.

I can''t think of any reason that SFQ should be maintained without the E
<grin>.  It makes very little sense to hard code parameters that the
user might wish or need to supply.  That''s the reason for ESFQ.  When
no
parameters are given, it _is_ SFQ; when there are parameters it complies
with ones wishes.

Name it what you like, but SFQ desperately needs to accept paramters,
and ESFQ should be the only SFQ.

gypsy
_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Seemingly Similar Threads

Search for more possibly parallel threads

LARTC - Jan 2005 - [PATCH] mark in u32

[PATCH] mark in u32

Re: [PATCH] mark in u32

Re: [PATCH] mark in u32

Re: [PATCH] mark in u32

Re: [PATCH] mark in u32

Re: [PATCH] mark in u32

Re: [PATCH] mark in u32

Re: [PATCH] mark in u32

Re: [PATCH] mark in u32

Re: [PATCH] mark in u32

Re: [PATCH] mark in u32

Re: [PATCH] mark in u32

Re: [PATCH] mark in u32

Re: [PATCH] mark in u32

Re: [PATCH] mark in u32

Re: [PATCH] mark in u32

Re: [PATCH] mark in u32

Re: [PATCH] mark in u32

Re: [PATCH] mark in u32

Re: [PATCH] mark in u32

Seemingly Similar Threads