Bryan O'Sullivan
2003-Jun-14 22:05 UTC
[klibc] [teeny tiny PATCH] Fix include/linux/bitops.h for userspace
Hi, Andrew - Looks like a recent change you fed to Linus broke the klibc build as of 2.5.71. Can you pass this fix along, please? ===== include/linux/bitops.h 1.4 vs edited ====--- 1.4/include/linux/bitops.h Thu Jun 5 23:37:30 2003 +++ edited/include/linux/bitops.h Sat Jun 14 22:02:01 2003 @@ -108,7 +108,7 @@ return (res & 0x0F) + ((res >> 4) & 0x0F); } -static inline unsigned long generic_hweight64(u64 w) +static inline unsigned long generic_hweight64(__u64 w) { #if BITS_PER_LONG < 64 return generic_hweight32((unsigned int)(w >> 32)) +
Andrew Morton
2003-Jun-14 22:13 UTC
[klibc] Re: [teeny tiny PATCH] Fix include/linux/bitops.h for userspace
"Bryan O'Sullivan" <bos@serpentine.com> wrote:> > Looks like a recent change you fed to Linus broke the klibc build as of > 2.5.71. Can you pass this fix along, please? > >... > -static inline unsigned long generic_hweight64(u64 w) > +static inline unsigned long generic_hweight64(__u64 w)I'd be tarred and feathered by slack-jawed hordes of inclusion-source purists. Cannot klibc define u64 or whatever?