tfpt review "/shelveset:netinterop1;REDMOND\jdeville" Comment : More tests for .net interop. This is taking advantage of the IronRuby selfhosting that Tomas blogged about in order to maintain isolation as I run different styles of requiring files. If you add Merlin/External/Languages/IronRuby/mspec/mspec/bin to your path, you should be able to run these with "mspec -fs /path/to/Interop/Load" -------------- next part -------------- A non-text attachment was scrubbed... Name: netinterop1.diff Type: application/octet-stream Size: 27353 bytes Desc: netinterop1.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20090126/f206b591/attachment-0001.obj>
On Mon, Jan 26, 2009 at 1:03 PM, Jim Deville <jdeville at microsoft.com> wrote:> tfpt review "/shelveset:netinterop1;REDMOND\jdeville" > Comment : > More tests for .net interop. This is taking advantage of the IronRuby selfhosting that Tomas blogged about in order to maintainWhere can I find Tomas'' blog? I''d like to subscribe but I didn''t see it on the IronRuby "people" page: http://ironruby.net/About/People Justin
The best way to answer your own question - post to a mailing list! I found a nice blogroll post by Oleg: http://www.tkachenko.com/blog/archives/000747.html Maybe someone can update the people page? I would but I haven''t created an account and am pressed for time as it is ... Justin On Mon, Jan 26, 2009 at 2:23 PM, Justin Bailey <jgbailey at gmail.com> wrote:> On Mon, Jan 26, 2009 at 1:03 PM, Jim Deville <jdeville at microsoft.com> wrote: >> tfpt review "/shelveset:netinterop1;REDMOND\jdeville" >> Comment : >> More tests for .net interop. This is taking advantage of the IronRuby selfhosting that Tomas blogged about in order to maintain > > Where can I find Tomas'' blog? I''d like to subscribe but I didn''t see > it on the IronRuby "people" page: > > http://ironruby.net/About/People > > Justin >
Fixed :) Tomas -----Original Message----- From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Justin Bailey Sent: Monday, January 26, 2009 2:24 PM To: ironruby-core at rubyforge.org Subject: Re: [Ironruby-core] Code Review: netinterop1 On Mon, Jan 26, 2009 at 1:03 PM, Jim Deville <jdeville at microsoft.com> wrote:> tfpt review "/shelveset:netinterop1;REDMOND\jdeville" > Comment : > More tests for .net interop. This is taking advantage of the IronRuby selfhosting that Tomas blogged about in order to maintainWhere can I find Tomas'' blog? I''d like to subscribe but I didn''t see it on the IronRuby "people" page: http://ironruby.net/About/People Justin _______________________________________________ Ironruby-core mailing list Ironruby-core at rubyforge.org http://rubyforge.org/mailman/listinfo/ironruby-core
Srivatsn, Can you take a look? JD> -----Original Message----- > From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core- > bounces at rubyforge.org] On Behalf Of Jim Deville > Sent: Monday, January 26, 2009 1:03 PM > To: IronRuby External Code Reviewers; Srivatsn Narayanan > Cc: ironruby-core at rubyforge.org > Subject: [Ironruby-core] Code Review: netinterop1 > > tfpt review "/shelveset:netinterop1;REDMOND\jdeville" > Comment : > More tests for .net interop. This is taking advantage of the IronRuby > selfhosting that Tomas blogged about in order to maintain isolation as > I run different styles of requiring files. If you add > Merlin/External/Languages/IronRuby/mspec/mspec/bin to your path, you > should be able to run these with "mspec -fs /path/to/Interop/Load" >
Sorry about the delay on this. Here are my comments:
1. Does MSpec have shared behaviors, like Rake or Bacon? If so, you should try
to remove the duplication of managing engines and whatnot that you have in
before/after blocks. For example:
shared ".NET Test" do
before { @engine = IronRuby.create_engine }
after { @engine = nil }
end
describe "Midifying and reloading a .NET BCL Assembly" do
behaves_like ".NET Test"
end
2. There''s a lot of duplication in the "Repeated loading of a .NET
BCL assembly with Strong name", and examples like that, so can you do
something like this:
it "only loads once with require followed by require" do
[true, false].each do |t|
@engine.execute("require ''System.Core, Version=3.5.0.0,
Culture=neutral, PublicKeyToken=b77a5c561934e089''").should == t
end
end
or where the loading mechanism changes
it "loads twice with load followed by load_assembly" do
[''load'', ''load_assembly''].each do |t|
@engine.execute("#{t} ''System.Core, Version=3.5.0.0,
Culture=neutral, PublicKeyToken=b77a5c561934e089''").should == true
end
end
Otherwise, it''s a great start!
> -----Original Message-----
> From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-
> bounces at rubyforge.org] On Behalf Of Jim Deville
> Sent: Friday, January 30, 2009 10:20 PM
> To: ironruby-core at rubyforge.org; IronRuby External Code Reviewers;
> Srivatsn Narayanan
> Subject: Re: [Ironruby-core] Code Review: netinterop1
>
> Srivatsn,
>
> Can you take a look?
>
> JD
>
> > -----Original Message-----
> > From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-
> > bounces at rubyforge.org] On Behalf Of Jim Deville
> > Sent: Monday, January 26, 2009 1:03 PM
> > To: IronRuby External Code Reviewers; Srivatsn Narayanan
> > Cc: ironruby-core at rubyforge.org
> > Subject: [Ironruby-core] Code Review: netinterop1
> >
> > tfpt review "/shelveset:netinterop1;REDMOND\jdeville"
> > Comment :
> > More tests for .net interop. This is taking advantage of the
> IronRuby
> > selfhosting that Tomas blogged about in order to maintain isolation
> as
> > I run different styles of requiring files. If you add
> > Merlin/External/Languages/IronRuby/mspec/mspec/bin to your path, you
> > should be able to run these with "mspec -fs
/path/to/Interop/Load"
> >
>
> _______________________________________________
> Ironruby-core mailing list
> Ironruby-core at rubyforge.org
> http://rubyforge.org/mailman/listinfo/ironruby-core
Updated shelveset, and diff.
JD
-----Original Message-----
From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at
rubyforge.org] On Behalf Of Jimmy Schementi
Sent: Wednesday, February 04, 2009 2:02 PM
To: ironruby-core at rubyforge.org; IronRuby External Code Reviewers; Srivatsn
Narayanan
Subject: Re: [Ironruby-core] Code Review: netinterop1
Sorry about the delay on this. Here are my comments:
1. Does MSpec have shared behaviors, like Rake or Bacon? If so, you should try
to remove the duplication of managing engines and whatnot that you have in
before/after blocks. For example:
shared ".NET Test" do
before { @engine = IronRuby.create_engine }
after { @engine = nil }
end
describe "Midifying and reloading a .NET BCL Assembly" do
behaves_like ".NET Test"
end
2. There''s a lot of duplication in the "Repeated loading of a .NET
BCL assembly with Strong name", and examples like that, so can you do
something like this:
it "only loads once with require followed by require" do
[true, false].each do |t|
@engine.execute("require ''System.Core, Version=3.5.0.0,
Culture=neutral, PublicKeyToken=b77a5c561934e089''").should == t
end
end
or where the loading mechanism changes
it "loads twice with load followed by load_assembly" do
[''load'', ''load_assembly''].each do |t|
@engine.execute("#{t} ''System.Core, Version=3.5.0.0,
Culture=neutral, PublicKeyToken=b77a5c561934e089''").should == true
end
end
Otherwise, it''s a great start!
> -----Original Message-----
> From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-
> bounces at rubyforge.org] On Behalf Of Jim Deville
> Sent: Friday, January 30, 2009 10:20 PM
> To: ironruby-core at rubyforge.org; IronRuby External Code Reviewers;
> Srivatsn Narayanan
> Subject: Re: [Ironruby-core] Code Review: netinterop1
>
> Srivatsn,
>
> Can you take a look?
>
> JD
>
> > -----Original Message-----
> > From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-
> > bounces at rubyforge.org] On Behalf Of Jim Deville
> > Sent: Monday, January 26, 2009 1:03 PM
> > To: IronRuby External Code Reviewers; Srivatsn Narayanan
> > Cc: ironruby-core at rubyforge.org
> > Subject: [Ironruby-core] Code Review: netinterop1
> >
> > tfpt review "/shelveset:netinterop1;REDMOND\jdeville"
> > Comment :
> > More tests for .net interop. This is taking advantage of the
> IronRuby
> > selfhosting that Tomas blogged about in order to maintain isolation
> as
> > I run different styles of requiring files. If you add
> > Merlin/External/Languages/IronRuby/mspec/mspec/bin to your path, you
> > should be able to run these with "mspec -fs
/path/to/Interop/Load"
> >
>
> _______________________________________________
> Ironruby-core mailing list
> Ironruby-core at rubyforge.org
> http://rubyforge.org/mailman/listinfo/ironruby-core
_______________________________________________
Ironruby-core mailing list
Ironruby-core at rubyforge.org
http://rubyforge.org/mailman/listinfo/ironruby-core
-------------- next part --------------
A non-text attachment was scrubbed...
Name: netinterop1.diff
Type: application/octet-stream
Size: 17906 bytes
Desc: netinterop1.diff
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20090205/0f59aac0/attachment.obj>
tfpt review "/shelveset:netinterop1;REDMOND\jdeville" Comment : Adds more netinterop tests related to methods. Adds these tests to snap. Adds tags for netinterop Modifies testsupport.cs (ClrAssembly) to make the Flag Value field public to match with other Flag classes, and to work better with Ruby testing. -------------- next part -------------- A non-text attachment was scrubbed... Name: netinterop1.diff Type: application/octet-stream Size: 10300 bytes Desc: netinterop1.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20090224/ca5dc5fe/attachment.obj>
Looks awesome. I''ll get around to specing this behavior on the website shortly. ~Jimmy Sent from my phone On Feb 24, 2009, at 5:06 PM, "Jim Deville" <jdeville at microsoft.com> wrote:> tfpt review "/shelveset:netinterop1;REDMOND\jdeville" > Comment : > Adds more netinterop tests related to methods. > Adds these tests to snap. > Adds tags for netinterop > Modifies testsupport.cs (ClrAssembly) to make the Flag Value field > public to match with other Flag classes, and to work better with > Ruby testing. > > > <netinterop1.diff> > _______________________________________________ > Ironruby-core mailing list > Ironruby-core at rubyforge.org > http://rubyforge.org/mailman/listinfo/ironruby-core
tfpt review "/shelveset:netinterop1;REDMOND\jdeville" Comment : Adds more netinterop tests related to methods. Adds these tests to snap. Reorganizes the ruby generictest folder Adds the command line tests to snap Adds tags for netinterop Modifies testsupport.cs (ClrAssembly) to make the Flag Value field public to match with other Flag classes, and to work better with Ruby testing. -------------- next part -------------- A non-text attachment was scrubbed... Name: netinterop1.diff Type: application/octet-stream Size: 10473 bytes Desc: netinterop1.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20090225/c562df17/attachment-0001.obj>
Do people prefer using "\" or "/" as the directory separator in Ruby code? I prefer "/" since all existing Ruby code uses that, and Ruby on windows understands it as well. Plus you don''t have to play the escape-slash game when using double-quoted strings. Also, some folks might be confused at the strange class/method names uses in these tests. They come from rowantest.*.dll, which are full of test cases IronPython uses for .NET interop testing, so we are just reusing them. However, it''s only a temporary solution, as we''ll probably move to a C#-code-inline approach which Jim is going to get working shortly. Regardless, I approve =)> -----Original Message----- > From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core- > bounces at rubyforge.org] On Behalf Of Jim Deville > Sent: Wednesday, February 25, 2009 3:01 PM > To: IronRuby External Code Reviewers > Cc: ironruby-core at rubyforge.org > Subject: [Ironruby-core] Code Review: netinterop1 > > tfpt review "/shelveset:netinterop1;REDMOND\jdeville" > Comment : > Adds more netinterop tests related to methods. > Adds these tests to snap. > Reorganizes the ruby generictest folder > Adds the command line tests to snap > Adds tags for netinterop > Modifies testsupport.cs (ClrAssembly) to make the Flag Value field > public to match with other Flag classes, and to work better with Ruby > testing. >
Where are you talking about / vs \? I''ll change it. The \ in context.rb has to stay because it gets put directly into app.config during the transforms. The odd class names (rowantest.*.dll) are in the git repo at Merlin\Main\Test\ClrAssembly. It''s a naked csproj (no solution), but it should compile from VS. I might remove it after inline support is finished. JD> -----Original Message----- > From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core- > bounces at rubyforge.org] On Behalf Of Jimmy Schementi > Sent: Wednesday, February 25, 2009 4:58 PM > To: ironruby-core at rubyforge.org; IronRuby External Code Reviewers > Subject: Re: [Ironruby-core] Code Review: netinterop1 > > Do people prefer using "\" or "/" as the directory separator in Ruby > code? I prefer "/" since all existing Ruby code uses that, and Ruby on > windows understands it as well. Plus you don''t have to play the escape- > slash game when using double-quoted strings. > > > Also, some folks might be confused at the strange class/method names > uses in these tests. They come from rowantest.*.dll, which are full of > test cases IronPython uses for .NET interop testing, so we are just > reusing them. However, it''s only a temporary solution, as we''ll > probably move to a C#-code-inline approach which Jim is going to get > working shortly. > > Regardless, I approve =) > > > -----Original Message----- > > From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core- > > bounces at rubyforge.org] On Behalf Of Jim Deville > > Sent: Wednesday, February 25, 2009 3:01 PM > > To: IronRuby External Code Reviewers > > Cc: ironruby-core at rubyforge.org > > Subject: [Ironruby-core] Code Review: netinterop1 > > > > tfpt review "/shelveset:netinterop1;REDMOND\jdeville" > > Comment : > > Adds more netinterop tests related to methods. > > Adds these tests to snap. > > Reorganizes the ruby generictest folder > > Adds the command line tests to snap > > Adds tags for netinterop > > Modifies testsupport.cs (ClrAssembly) to make the Flag Value field > > public to match with other Flag classes, and to work better with Ruby > > testing. > > > > _______________________________________________ > Ironruby-core mailing list > Ironruby-core at rubyforge.org > http://rubyforge.org/mailman/listinfo/ironruby-core