Ironruby core - Oct 2008 - Code Review: bugfixes-10

tfpt review "/shelveset:bugfixes-10;REDMOND\jflam"
Comment  :
  Fixes find bug, adds thunks for system and system.drawing assemblies and
forces ironruby to use MRI gem path


-------------- next part --------------
A non-text attachment was scrubbed...
Name: bugfixes-10.diff
Type: application/octet-stream
Size: 55160 bytes
Desc: bugfixes-10.diff
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20081021/17d825fd/attachment-0001.obj>

Two comments:

* The change from ironruby to ruby in the ExecutionContext might break a lang
test. You can check with rake mspec:lang.
* Should we default the .NET namespaces to do a default require, without the
file, but allow that require to be overridden with a file?

Other than that it looks good.
-----Original Message-----
From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at
rubyforge.org] On Behalf Of John Lam (IRONRUBY)
Sent: Tuesday, October 21, 2008 4:14 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: [Ironruby-core] Code Review: bugfixes-10

tfpt review "/shelveset:bugfixes-10;REDMOND\jflam"
Comment  :
  Fixes find bug, adds thunks for system and system.drawing assemblies and
forces ironruby to use MRI gem path