tfpt review "/shelveset:RandomRubyFixes04;REDMOND\curth" Comment : Eliminated static field BasicSocket.DoNotReverseLookup in favor of a property on the context. Fixed two variants of String.slice! to work the same (inconsistent :) way as MRI Stub implementation of Process.uid Added exception class ECONNABORTED Naive support for non-Fixnum result of "hash" Implemented IoOps.sysread -- Curt Hagenlocher curth at microsoft.com -------------- next part -------------- A non-text attachment was scrubbed... Name: RandomRubyFixes04.diff Type: application/octet-stream Size: 65354 bytes Desc: RandomRubyFixes04.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20081021/de626fc9/attachment-0001.obj>
Looks good. -----Original Message----- From: Curt Hagenlocher Sent: Tuesday, October 21, 2008 7:28 AM To: IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: Code Review: RandomRubyFixes04 tfpt review "/shelveset:RandomRubyFixes04;REDMOND\curth" Comment : Eliminated static field BasicSocket.DoNotReverseLookup in favor of a property on the context. Fixed two variants of String.slice! to work the same (inconsistent :) way as MRI Stub implementation of Process.uid Added exception class ECONNABORTED Naive support for non-Fixnum result of "hash" Implemented IoOps.sysread -- Curt Hagenlocher curth at microsoft.com