tfpt review "/shelveset:NoSymbolId1;REDMOND\tomat" Removes SymbolIds from IronRuby compiler and runtime. Still keeps SymbolId as a representation of Symbol Ruby class. The plan is to replace SymbolId completely by System.String with interning table on RubyContext (the integer values will be unique per script runtime). The table will hold on additional information about the strings (encoding, taint, instance variables, etc.). Tomas -------------- next part -------------- A non-text attachment was scrubbed... Name: NoSymbolId1.diff Type: application/octet-stream Size: 421046 bytes Desc: NoSymbolId1.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20081003/7f1f3d8b/attachment-0001.obj>
Changes look good, overall. I like the approach. In Tokenizer.cs, you replaced Symbols.Minus with the hardcoded "-" -- but Symbols.Minus has separately been redefined to "-". Best to continue to use the symbolic name, no? -----Original Message----- From: Tomas Matousek Sent: Friday, October 03, 2008 3:08 PM To: IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: Code Review: NoSymbolId1 tfpt review "/shelveset:NoSymbolId1;REDMOND\tomat" Removes SymbolIds from IronRuby compiler and runtime. Still keeps SymbolId as a representation of Symbol Ruby class. The plan is to replace SymbolId completely by System.String with interning table on RubyContext (the integer values will be unique per script runtime). The table will hold on additional information about the strings (encoding, taint, instance variables, etc.). Tomas
OK, I''ve undone this line for now. Tomas -----Original Message----- From: Curt Hagenlocher Sent: Friday, October 03, 2008 5:12 PM To: Tomas Matousek; IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: RE: Code Review: NoSymbolId1 Changes look good, overall. I like the approach. In Tokenizer.cs, you replaced Symbols.Minus with the hardcoded "-" -- but Symbols.Minus has separately been redefined to "-". Best to continue to use the symbolic name, no? -----Original Message----- From: Tomas Matousek Sent: Friday, October 03, 2008 3:08 PM To: IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: Code Review: NoSymbolId1 tfpt review "/shelveset:NoSymbolId1;REDMOND\tomat" Removes SymbolIds from IronRuby compiler and runtime. Still keeps SymbolId as a representation of Symbol Ruby class. The plan is to replace SymbolId completely by System.String with interning table on RubyContext (the integer values will be unique per script runtime). The table will hold on additional information about the strings (encoding, taint, instance variables, etc.). Tomas