Ironruby core - Oct 2008 - Code Review: RandomRubyFixes03

tfpt review "/shelveset:RandomRubyFixes03;REDMOND\curth"

Comment  :
  Implement unpack directive L as equivalent to I on this platform
  Fix stack overflow resulting from inspecting recursive objects
  Fix instance variable operations to use consistent context/scope variable type
  Implement Proc.binding
  Implement Thread.abort_on_exception, Thread.value.  Flow exceptions across
Thread.join.  (ThreadOps is now in need of some refactoring...)
  Supply stack trace when there''s no handler

--
Curt Hagenlocher
curth at microsoft.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: RandomRubyFixes03.diff
Type: application/octet-stream
Size: 31001 bytes
Desc: RandomRubyFixes03.diff
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20081002/84a4730c/attachment-0001.obj>

Missing overflow check in ThreadOps.cs:259

if (!self.Join((int)(timeout * 1000))) {

Other than that looks good.

Tomas


-----Original Message-----
From: Curt Hagenlocher
Sent: Thursday, October 02, 2008 3:26 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Code Review: RandomRubyFixes03

tfpt review "/shelveset:RandomRubyFixes03;REDMOND\curth"

Comment  :
  Implement unpack directive L as equivalent to I on this platform
  Fix stack overflow resulting from inspecting recursive objects
  Fix instance variable operations to use consistent context/scope variable type
  Implement Proc.binding
  Implement Thread.abort_on_exception, Thread.value.  Flow exceptions across
Thread.join.  (ThreadOps is now in need of some refactoring...)
  Supply stack trace when there''s no handler

--
Curt Hagenlocher
curth at microsoft.com