Tfpt review /shelveset:DirFix;srivatsn Fixes RubyForge [#21126] Dir.glob **/ returns duplicate entries. The code was enumerating the current folder''s and its subfolders'' files recursively and hence everything got counted twice. The fix tracks that with a flag. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080825/af2aab39/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: Dirfix.diff Type: application/octet-stream Size: 2268 bytes Desc: Dirfix.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080825/af2aab39/attachment.obj>
Looks good. Tomas From: Srivatsn Narayanan Sent: Monday, August 25, 2008 12:41 PM To: IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: Code Review: DirFix Tfpt review /shelveset:DirFix;srivatsn Fixes RubyForge [#21126] Dir.glob **/ returns duplicate entries. The code was enumerating the current folder''s and its subfolders'' files recursively and hence everything got counted twice. The fix tracks that with a flag. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080825/271b4791/attachment.html>