tfpt review "/shelveset:bugs-2;REDMOND\jflam" Comment : - Fixes Rubyforge #21069: Array#delete on a frozen array throws a TypeError even if modification doesn''t take place - Fixes Array#flatten frozen bug (related) - Fixes additional spec failure in Array#flatten where to_ary not called on elements - Punting for now on the fix for Array#flatten that dispatches by calling Array#flatten on elements - right now we don''t have a good mechanism to pass our ''seen'' dictionary to callers across the dynamic invocation boundary (see TODO) - Fixes Rubyforge #20125: MatchData#inspect returns incorrect representation of matchdata -------------- next part -------------- A non-text attachment was scrubbed... Name: bugs-2.diff Type: application/octet-stream Size: 9688 bytes Desc: bugs-2.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080822/5e3d7efb/attachment-0001.obj>
Looks good. -----Original Message----- From: John Lam (IRONRUBY) Sent: Friday, August 22, 2008 2:33 PM To: IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: Code Review: bugs-2 tfpt review "/shelveset:bugs-2;REDMOND\jflam" Comment : - Fixes Rubyforge #21069: Array#delete on a frozen array throws a TypeError even if modification doesn''t take place - Fixes Array#flatten frozen bug (related) - Fixes additional spec failure in Array#flatten where to_ary not called on elements - Punting for now on the fix for Array#flatten that dispatches by calling Array#flatten on elements - right now we don''t have a good mechanism to pass our ''seen'' dictionary to callers across the dynamic invocation boundary (see TODO) - Fixes Rubyforge #20125: MatchData#inspect returns incorrect representation of matchdata