Hello, I work for the company Smartjog (http://smatjog.com/) where we use a modified version of Icecast. We would like to contribute back those patchs, and hopefully have them merged in the official repository. I have posted them on the patch tracker, so feel free to leave a comment on them. Some of those patch are based on the work done by Niv Sardi (see http://lists.xiph.org/pipermail/icecast-dev/2010-July/001877.html). Best regards. Laurent
ldefert <ldefert at smartjog.com> writes:> I work for the company Smartjog (http://smatjog.com/) where we use a > modified version of Icecast. We would like to contribute back those patchs, > and hopefully have them merged in the official repository. I have posted > them on the patch tracker, so feel free to leave a comment on them.^^^^^^^^^^^^^ for those (like me) who wonder what that is: https://trac.xiph.org/report/9?asc=0&sort=created&USER=anonymous | #1814 | FLV streaming support | | #1812 | Handle a source using POST and PUT request | ^^^^^^^^^ so that just lets them in, then you need to do SOURCE-like auth anyway, and have SOURCE-capable software, is it really worth it ? that was a hack made to be able to push directly with ffmpeg POST and not have to use a libshout client in the middle. not saying you should https://github.com/xaiki/IceCast/commit/25825ebb638a6d32a99d4ecb79bfed19804429b9 but maybe. | #1811 | Fix streaming on iPhone | ^^^^^^^^^ have you actually checked it's needed, I remember pulling this one off my tree after a discussion on #icecast. | #1810 | Race conditions fix | ^^^^^^^^^ that's a bucketload of more locking, any performance data ? Cheers, -- Niv Sardi
Hello,> | #1812 | Handle a source using POST and PUT request | > ^^^^^^^^^ > so that just lets them in, then you need to do SOURCE-like auth anyway, > and have SOURCE-capable software, is it really worth it ? that was a > hack made to be able to push directly with ffmpeg POST and not have to > use a libshout client in the middle. > > not saying you should > >https://github.com/xaiki/IceCast/commit/25825ebb638a6d32a99d4ecb79bfed19804429b9> > but maybe.Well, handling POST/PUT request and disabling authentication are two different things. If we want to disable authentication, let's add an option for it.> | #1811 | Fix streaming on iPhone | > ^^^^^^^^^ > have you actually checked it's needed, I remember pulling this one off > my tree after a discussion on #icecast.No, any feedback about this would be welcome.> | #1810 | Race conditions fix | > ^^^^^^^^^ > that's a bucketload of more locking, any performance data ?I haven't done any performance testing, however most of the locks I added aren't located in thread's main loop. I don't think this patch will have any significative impact on performances. Best regards Laurent> > Cheers, > -- > Niv Sardi > > _______________________________________________ > Icecast-dev mailing list > Icecast-dev at xiph.org > http://lists.xiph.org/mailman/listinfo/icecast-dev