Icecast dev - Aug 2004 - Strange change in icecast kh14 for IP logging

Hello,
Karl, you added a compile-time flag to enable IP logging in icecast.
But, this changed a lot the log procuded:
81.53.41.160 - - [30/Nov/2003:10:09:11 +0100] "GET /admin/metadata
HTTP/1.0" 200 155 "-" "ices/0.3 libshout/2.0-kh22" 0
81.53.41.160 - - [30/Nov/2003:11:20:14 +0100] "SOURCE /radio-bro-gwened.mp3
HTTP/1.0" 200 19 "-" "ices/0.3 libshout/2.0-kh22" 4264
81.53.41.160 - - [30/Nov/2003:11:20:14 +0100] "SOURCE /radio-bro-gwened.ogg
HTTP/1.0" 200 19 "-" "IceS 2.0-kh48" 40805
[30/Nov/2003:11:20:18 +0100] - - - "GET /admin/metadata HTTP/1.0" 200
155 "-" "ices/0.3 libshout/2.0-kh22" 0
[30/Nov/2003:11:20:28 +0100] - - - "SOURCE /radio-bro-gwened.mp3
HTTP/1.0" 200 19 "-" "ices/0.3 libshout/2.0-kh22" 11
[30/Nov/2003:11:20:29 +0100] - - - "SOURCE /radio-bro-gwened.ogg
HTTP/1.0" 200 19 "-" "IceS 2.0-kh48" 10

I thing the log should look like:
- - -  [30/Nov/2003:11:20:14 +0100] "SOURCE /radio-bro-gwened.ogg
HTTP/1.0" 200 19 "-" "IceS 2.0-kh48" 40805
instead of what it looks like now...
The new log format is incompatible with the previous one...

Chris
--- >8 ----
List archives:  http://www.xiph.org/archives/
icecast project homepage: http://www.icecast.org/
To unsubscribe from this list, send a message to
'icecast-dev-request@xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is
needed.
Unsubscribe messages sent to the list will be ignored/filtered.

The problem is for statistics tools like Webalizer, which is expecting CLF log
format
Common Log Format (CLF)
    "%h %l %u %t \"%r\" %>s %b"
NCSA extended/combined log format
    "%h %l %u %t \"%r\" %>s %b \"%{Referer}i\"
\"%{User-agent}i\""
Referer log format
    "%{Referer}i -> %U"
Agent (Browser) log format
    "%{User-agent}i"

This tool cannot be used if the format doesn't match..
So I think the previous format was better (regardless to IP logging, because IP
or - is similar for Webalizer).

Chris
--- >8 ----
List archives:  http://www.xiph.org/archives/
icecast project homepage: http://www.icecast.org/
To unsubscribe from this list, send a message to
'icecast-dev-request@xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is
needed.
Unsubscribe messages sent to the list will be ignored/filtered.

> What I did notice is that the date field is not first, even though it's
> date ordered. I personally didn't like that, so I just moved the date
> field. opinions ?
Please don't change the ordering of the fields. It's quite deliberately 
ordered for compatibility with the Apache Common Log Format. (hmm... or is it 
the Combined Log Format? I forget...)

Mike

--- >8 ----
List archives:  http://www.xiph.org/archives/
icecast project homepage: http://www.icecast.org/
To unsubscribe from this list, send a message to
'icecast-dev-request@xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is
needed.
Unsubscribe messages sent to the list will be ignored/filtered.

On Wed, 2003-12-03 at 12:31, iceuse@kezako.net wrote:
> Hello,
> Karl, you added a compile-time flag to enable IP logging in icecast.
> But, this changed a lot the log procuded:
> 81.53.41.160 - - [30/Nov/2003:10:09:11 +0100] "GET /admin/metadata
HTTP/1.0" 200 155 "-" "ices/0.3 libshout/2.0-kh22" 0
> 81.53.41.160 - - [30/Nov/2003:11:20:14 +0100] "SOURCE
/radio-bro-gwened.mp3 HTTP/1.0" 200 19 "-" "ices/0.3
libshout/2.0-kh22" 4264
> 81.53.41.160 - - [30/Nov/2003:11:20:14 +0100] "SOURCE
/radio-bro-gwened.ogg HTTP/1.0" 200 19 "-" "IceS
2.0-kh48" 40805
> [30/Nov/2003:11:20:18 +0100] - - - "GET /admin/metadata HTTP/1.0"
200 155 "-" "ices/0.3 libshout/2.0-kh22" 0
> [30/Nov/2003:11:20:28 +0100] - - - "SOURCE /radio-bro-gwened.mp3
HTTP/1.0" 200 19 "-" "ices/0.3 libshout/2.0-kh22" 11
> [30/Nov/2003:11:20:29 +0100] - - - "SOURCE /radio-bro-gwened.ogg
HTTP/1.0" 200 19 "-" "IceS 2.0-kh48" 10
> 
> I thing the log should look like:
> - - -  [30/Nov/2003:11:20:14 +0100] "SOURCE /radio-bro-gwened.ogg
HTTP/1.0" 200 19 "-" "IceS 2.0-kh48" 40805
> instead of what it looks like now...
> The new log format is incompatible with the previous one...
this is true, and it's something I started experimenting with but
haven't yet completed, but the idea is to have a configure flag
to either log IP or disable logging of ip, not sure which to make the
default, probably enabled.

What I did notice is that the date field is not first, even though it's
date ordered. I personally didn't like that, so I just moved the date
field. opinions ?

BTW for any testers, just make CFLAGS=-DHAVE_IP_LOGGING to get the
previous format.

karl.

<p>--- >8 ----
List archives:  http://www.xiph.org/archives/
icecast project homepage: http://www.icecast.org/
To unsubscribe from this list, send a message to
'icecast-dev-request@xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is
needed.
Unsubscribe messages sent to the list will be ignored/filtered.