On 19/02/02 06:14, Jack Moffitt shaped the electrons to say:> > well, at 128kbps bitrate, it's only 6 seconds of data. 30 seconds would > > have been more reasonable, how does everybody think? it might have to be > > varied based on the bitrate of the stream. > > Good point. I will make this configurable in the end. 6 seconds is too > little. I'll see what I can do to track by seconds instead of buffers.It's partially done in the patch I've sent you, completelly done in my current version... I can send you the second patch, you will save some work. <p> -- ricardo "I just stopped using Windows and now you tell me to use Mirrors?" - said Aunt Tillie, just before downloading 2.5.3 kernel. --- >8 ---- List archives: http://www.xiph.org/archives/ icecast project homepage: http://www.icecast.org/ To unsubscribe from this list, send a message to 'icecast-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
Ricardo Galli wrote:>On 19/02/02 06:14, Jack Moffitt shaped the electrons to say: > >>Good point. I will make this configurable in the end. 6 seconds is too >>little. I'll see what I can do to track by seconds instead of buffers. >> > >It's partially done in the patch I've sent you, completelly done in my >current version... I can send you the second patch, you will save some work. >how is the calculation being done? do you extract the bitrate from the stream data, or do you use a different method? I'd advocate *that* different method though. actually, what i mean is, since we have the stat of the source stream about the time it has connected and the number of bytes it has read from the encoder, we can use this to calculate the bitrate instead of trying to extract hard info from stream. this will work with many things in general, including VBR (we're now taking the average bitrate, not a particular bitrate of a frame). let me know if this is how you do it ... liulk <p><p>--- >8 ---- List archives: http://www.xiph.org/archives/ icecast project homepage: http://www.icecast.org/ To unsubscribe from this list, send a message to 'icecast-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
On 19/02/02 18:09, Likai Liu shaped the electrons to say:> >It's partially done in the patch I've sent you, completelly done in my > >current version... I can send you the second patch, you will save some > > work. > > how is the calculation being done? do you extract the bitrate from the > stream data, or do you use a different method? I'd advocate *that* > different method though. actually, what i mean is, since we have theBy assigning a timestamp to each packet read from the source socket. I think the only sane way to do it. BTW, congratulations to the developers, I am loving the code, clear, simple, concise, elegant. -- ricardo "I just stopped using Windows and now you tell me to use Mirrors?" - said Aunt Tillie, just before downloading 2.5.3 kernel. --- >8 ---- List archives: http://www.xiph.org/archives/ icecast project homepage: http://www.icecast.org/ To unsubscribe from this list, send a message to 'icecast-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.