freebsd stable - Aug 2020 - EFISYS shortcuts on Xfce desktops

> On 18 Aug 2020, at 11:23, O'Connor, Daniel <darius at
dons.net.au> wrote:
> 
>> On 8 Aug 2020, at 18:03, Guido Falsi via freebsd-stable
<freebsd-stable at freebsd.org> wrote:
>> Hope this helps.
> 
> Thanks for this, I got it working by specifying block.device (twice, once
for /dev/msdosfs/EFISYS and once for /dev/gptid/<mumble>). Is there a way
it can key off (say) the volume name or UUID instead?
> 
> I tried a few keys like volume.uuid and volume.label but they don't
work. Perhaps that is because they are only filled in after the preprobe, hence
the rules don't match until after they could possibly take effect.
Naturally 5 minutes after sending this I worked it out on my own..
[clmet 1:58] ~> cat
/usr/local/etc/hal/fdi/policy/20thirdparty/10-ignore-efi.fdi
<?xml version="1.0" encoding="utf-8"?>

<deviceinfo version="0.2">
  <device>
    <match key="volume.fstype" string="vfat">
      <match key="volume.label" string="EFISYS">
        <merge key="volume.ignore"
type="bool">true</merge>
      </match>
    </match>
  </device>
</deviceinfo>

I discovered this:
      <!-- EFI firmware partitions -->
      <match key="volume.fstype" string="vfat">
        <match key="volume.label" string="EFI">
          <merge key="volume.ignore"
type="bool">true</merge>
        </match>
      </match>

in /usr/local/share/hal/fdi/policy/10osvendor/20-storage-methods.fdi

I think it would make sense to patch the port to add another stanza which
matches EFISYS as well as EFI.

What do you think?

Thanks.

--
Daniel O'Connor
"The nice thing about standards is that there
are so many of them to choose from."
 -- Andrew Tanenbaum

> On 18 Aug 2020, at 11:29, O'Connor, Daniel <darius at
dons.net.au> wrote:
> I think it would make sense to patch the port to add another stanza which
matches EFISYS as well as EFI.
> 
> What do you think?
I was going to file a bug but bugzilla is having a nap right now.

This patch works for me:
[midget 12:47] /tmp/hal >cat
files/patch-fdi_policy_10osvendor_20-storage-methods.fdi
--- fdi/policy/10osvendor/20-storage-methods.fdi.orig   2020-08-18
12:41:54.869810000 +0930
+++ fdi/policy/10osvendor/20-storage-methods.fdi        2020-08-18
12:42:14.480922000 +0930
@@ -104,6 +104,9 @@
        <match key="volume.label" string="EFI">
          <merge key="volume.ignore"
type="bool">true</merge>
        </match>
+       <match key="volume.label" string="EFISYS">
+         <merge key="volume.ignore"
type="bool">true</merge>
+       </match>
       </match>

       <match key="volume.fstype"
string_outof="ntfs;vfat">

--
Daniel O'Connor
"The nice thing about standards is that there
are so many of them to choose from."
 -- Andrew Tanenbaum