freebsd stable - Mar 2018 - [HEADS UP] - OFED/RDMA stack update

On 03/17/2018 13:03, Hans Petter Selasky wrote:
> On 03/17/18 20:52, Navdeep Parhar wrote:
>> Hold your horses.? Do you have confirmation from the affected party
that
>> the shims are adequate for them?? I have been waiting for that before
>> looking at this branch.
> 
> Hi Navdeep,
> 
> Mellanox has received an API list from at least one party, and has taken
> the action to support all the required APIs.
> 
>> Is the iw_cxgbe breakage a simple merge conflict as previously
discussed
>> or do the shims require driver changes?? 
> 
> It is a merge conflict. The code already compiles in 12-current.
I tried backing out r329391 and r329017 in a local copy and then was
able to merge r320418, r323082, and r326169 in that order without any
conflicts.  But iw_cxgbe/cm.c still doesn't compile in the projects
branch because it has some socket code that relies on some of glebius's
changes available only in head (I checked with him and they aren't
MFC'able).  I'm trying to figure out what to do about those.

And what about the cxgb breakage?  Is there any simple way to make an
old style driver work with the new stack?  T3 iw_cxgb in head was
retired before the ofed overhaul.

Regards,
Navdeep

On 03/20/18 21:07, Navdeep Parhar wrote:
> And what about the cxgb breakage?  Is there any simple way to make an
> old style driver work with the new stack?  T3 iw_cxgb in head was
> retired before the ofed overhaul.
Hi,

The most simple way is to pull this driver from Linux 4.9, including 
libcxgb for user-space, if possible, though I'm not sure about the 
FreeBSD specific areas of iWarp and socket handling. I think you know 
that part better than I do.

After pulling from Linux 4.9 you need to extend this change to cover the 
iw_cxgb:

https://svnweb.freebsd.org/changeset/base/330508

Or can you retire iw_cxgb?

--HPS

Hi Navdeep, 

What's the current iWARP status on the project branch? 
If it's ready we'd like to merge it to FreeBSD11-STABLE immediately. 

-Meny


-----Original Message-----
From: Navdeep Parhar [mailto:nparhar at gmail.com] On Behalf Of Navdeep Parhar
Sent: Tuesday, March 20, 2018 10:08 PM
To: Hans Petter Selasky <hps at selasky.org>; Konstantin Belousov <kib
at freebsd.org>; 'freebsd-infiniband at freebsd.org'
<freebsd-infiniband at freebsd.org>; freebsd-drivers <freebsd-drivers
at mellanox.com>; Meny Yossefi <menyy at mellanox.com>;
'FreeBSD-stable at FreeBSD.org' <FreeBSD-stable at FreeBSD.org>;
freebsd-arch <freebsd-arch at freebsd.org>
Subject: Re: [HEADS UP] - OFED/RDMA stack update

On 03/17/2018 13:03, Hans Petter Selasky wrote:
> On 03/17/18 20:52, Navdeep Parhar wrote:
>> Hold your horses.? Do you have confirmation from the affected party 
>> that the shims are adequate for them?? I have been waiting for that 
>> before looking at this branch.
> 
> Hi Navdeep,
> 
> Mellanox has received an API list from at least one party, and has 
> taken the action to support all the required APIs.
> 
>> Is the iw_cxgbe breakage a simple merge conflict as previously 
>> discussed or do the shims require driver changes?
> 
> It is a merge conflict. The code already compiles in 12-current.
I tried backing out r329391 and r329017 in a local copy and then was able to
merge r320418, r323082, and r326169 in that order without any conflicts.  But
iw_cxgbe/cm.c still doesn't compile in the projects branch because it has
some socket code that relies on some of glebius's changes available only in
head (I checked with him and they aren't MFC'able).  I'm trying to
figure out what to do about those.

And what about the cxgb breakage?  Is there any simple way to make an old style
driver work with the new stack?  T3 iw_cxgb in head was retired before the ofed
overhaul.

Regards,
Navdeep