On 03/17/18 20:52, Navdeep Parhar wrote:> Hold your horses. Do you have confirmation from the affected party that > the shims are adequate for them? I have been waiting for that before > looking at this branch.Hi Navdeep, Mellanox has received an API list from at least one party, and has taken the action to support all the required APIs.> Is the iw_cxgbe breakage a simple merge conflict as previously discussed > or do the shims require driver changes?It is a merge conflict. The code already compiles in 12-current.> If they don't then it should be > possible to drop the iw_cxgbe from head into this branch and it should > just work, is that correct?Yes, it shouldn't be too hard to do and I would appreciate if Chelsio could throw some resources at this ASAP. I believe the new code will benefit everyone using Infiniband/RoCE and iWarp with FreeBSD. --HPS
On Sat, Mar 17, 2018 at 09:03:40PM +0100, Hans Petter Selasky wrote:> On 03/17/18 20:52, Navdeep Parhar wrote: > >Hold your horses. Do you have confirmation from the affected party that > >the shims are adequate for them? I have been waiting for that before > >looking at this branch. > > Hi Navdeep, > > Mellanox has received an API list from at least one party, and has taken the > action to support all the required APIs. > > >Is the iw_cxgbe breakage a simple merge conflict as previously discussed > >or do the shims require driver changes? > > It is a merge conflict. The code already compiles in 12-current.Ok that doesn't sound that bad. I'll take a look early this week. Regards, Navdeep> > >If they don't then it should be > >possible to drop the iw_cxgbe from head into this branch and it should > >just work, is that correct? > > Yes, it shouldn't be too hard to do and I would appreciate if Chelsio could > throw some resources at this ASAP. I believe the new code will benefit > everyone using Infiniband/RoCE and iWarp with FreeBSD. > > --HPS > _______________________________________________ > freebsd-arch at freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-arch > To unsubscribe, send any mail to "freebsd-arch-unsubscribe at freebsd.org"
On 03/17/2018 13:03, Hans Petter Selasky wrote:> On 03/17/18 20:52, Navdeep Parhar wrote: >> Hold your horses.? Do you have confirmation from the affected party that >> the shims are adequate for them?? I have been waiting for that before >> looking at this branch. > > Hi Navdeep, > > Mellanox has received an API list from at least one party, and has taken > the action to support all the required APIs. > >> Is the iw_cxgbe breakage a simple merge conflict as previously discussed >> or do the shims require driver changes?? > > It is a merge conflict. The code already compiles in 12-current.I tried backing out r329391 and r329017 in a local copy and then was able to merge r320418, r323082, and r326169 in that order without any conflicts. But iw_cxgbe/cm.c still doesn't compile in the projects branch because it has some socket code that relies on some of glebius's changes available only in head (I checked with him and they aren't MFC'able). I'm trying to figure out what to do about those. And what about the cxgb breakage? Is there any simple way to make an old style driver work with the new stack? T3 iw_cxgb in head was retired before the ofed overhaul. Regards, Navdeep