Teske, Devin
2013-Nov-12 16:09 UTC
[Regression] SVN r244198 broke double-quotes in /etc/sysctl.conf*
Hi all, It appears as though SVN r244198 introduced a regression. One that is affecting HEAD and stable/10 (for upcoming 10.0-R) and was introduced 10 months ago (but does not appear to have made it into 9.x yet or even stable/9). The regression introduced by r244198 is that: Whilst "sysctl -f /etc/sysctl.conf" will parse parameters with quoted values... "service sysctl start" will not work with quoted values. It seems to me that /etc/rc.d/sysctl should be using "sysctl -f file" to be consistent. For example... cat <<EOF >> /etc/sysctl.conf net.inet.ip.forwarding="0" EOF sysctl net.inet.ip.forwarding=1 sysctl net.inet.ip.forwarding # reports 1 service sysctl start # error: /etc/rc.d/sysctl: WARNING: unable to set net.inet.ip.forwarding="0" # value unchanged sysctl -f /etc/sysctl.conf sysctl net.inet.ip.forwarding # value changed to 0 -- Devin _____________ The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you.
Teske, Devin
2013-Nov-12 16:12 UTC
[Regression] SVN r244198 broke double-quotes in /etc/sysctl.conf*
Nevermind... Recall that message... I was testing on 9.x and that was the issue. NO REGRESSION FOUND -- Devin On Nov 12, 2013, at 8:09 AM, Teske, Devin wrote:> Hi all, > > It appears as though SVN r244198 introduced a regression. > One that is affecting HEAD and stable/10 (for upcoming 10.0-R) > and was introduced 10 months ago (but does not appear to > have made it into 9.x yet or even stable/9). > > The regression introduced by r244198 is that: > > Whilst "sysctl -f /etc/sysctl.conf" will parse parameters with > quoted values... > > "service sysctl start" will not work with quoted values. > > It seems to me that /etc/rc.d/sysctl should be using "sysctl -f file" > to be consistent. > > For example... > > cat <<EOF >> /etc/sysctl.conf > net.inet.ip.forwarding="0" > EOF > > sysctl net.inet.ip.forwarding=1 > sysctl net.inet.ip.forwarding > # reports 1 > service sysctl start > # error: /etc/rc.d/sysctl: WARNING: unable to set net.inet.ip.forwarding="0" > # value unchanged > sysctl -f /etc/sysctl.conf > sysctl net.inet.ip.forwarding > # value changed to 0 > -- > Devin >_____________ The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you.