On recent -stable I got a lots of (see subj) now due to CTF changes in *.mk files. I have WITHOUT_CDDL=yes in my /etc/src.conf and WITHOUT_CDDL have wider scope than WITHOUT_CTF suggested, but WITHOUT_CDDL is not checked in recent CTF changes. Please fix this thing.
On 20.10.2012 5:06, Andrey Chernov wrote:> On recent -stable I got a lots of (see subj) now due to CTF changes in > *.mk files. > I have > WITHOUT_CDDL=yes > in my /etc/src.conf and WITHOUT_CDDL have wider scope than WITHOUT_CTF > suggested, but WITHOUT_CDDL is not checked in recent CTF changes. > Please fix this thing. >BTW, I got that ${CTFCONVERT_CMD} expands to empty string even placing WITHOUT_CTF=yes into /etc/src.conf
On Friday, October 19, 2012 09:06:55 PM Andrey Chernov wrote:> On recent -stable I got a lots of (see subj) now due to CTF changes in > *.mk files. > I have > WITHOUT_CDDL=yes > in my /etc/src.conf and WITHOUT_CDDL have wider scope than WITHOUT_CTF > suggested, but WITHOUT_CDDL is not checked in recent CTF changes. > Please fix this thing.Which stable? -- John Baldwin
On 20.10.2012 16:38, John Baldwin wrote:> On Friday, October 19, 2012 09:06:55 PM Andrey Chernov wrote: >> On recent -stable I got a lots of (see subj) now due to CTF changes in >> *.mk files. >> I have >> WITHOUT_CDDL=yes >> in my /etc/src.conf and WITHOUT_CDDL have wider scope than WITHOUT_CTF >> suggested, but WITHOUT_CDDL is not checked in recent CTF changes. >> Please fix this thing. > > Which stable?stable-9
Those lines cause this error:
.if ${MK_CTF} != "no"
CTFCONVERT_CMD= ${CTFCONVERT} ${CTFFLAGS} ${.TARGET}
.elif ${MAKE_VERSION} >= 5201111300
CTFCONVERT_CMD.else
CTFCONVERT_CMD= @:
.endif
My make version is 9201206140
So, either the check for >= 5201111300 is incorrect or change for empty
make variables expansion is not merged into stable-9
On 21.10.2012 1:29, Andrey Chernov wrote:> On 20.10.2012 16:38, John Baldwin wrote:
>> On Friday, October 19, 2012 09:06:55 PM Andrey Chernov wrote:
>>> On recent -stable I got a lots of (see subj) now due to CTF changes
in
>>> *.mk files.
>>> I have
>>> WITHOUT_CDDL=yes
>>> in my /etc/src.conf and WITHOUT_CDDL have wider scope than
WITHOUT_CTF
>>> suggested, but WITHOUT_CDDL is not checked in recent CTF changes.
>>> Please fix this thing.
>>
>> Which stable?
>
> stable-9
>