Most libFLAC code don't have a space between if and a parenthesis, so the patch removes them from lpc_intrin_sseNN.c files. -------------- next part -------------- A non-text attachment was scrubbed... Name: 02_spaces.patch Type: application/octet-stream Size: 3861 bytes Desc: not available URL: <http://lists.xiph.org/pipermail/flac-dev/attachments/20170218/5efa74c7/attachment.obj>
lvqcl wrote:> Most libFLAC code don't have a space between if and a parenthesis, > so the patch removes them from lpc_intrin_sseNN.c files.I don't really agree with this one. If anything I think we should slowly move to making the code insert a space between the `if` and the open parenthesis because its easier to read. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
I agree with Erik regarding this patch. On Feb 19, 2017, at 12:17 PM, Erik de Castro Lopo <mle+la at mega-nerd.com> wrote:> lvqcl wrote: >> Most libFLAC code don't have a space between if and a parenthesis, >> so the patch removes them from lpc_intrin_sseNN.c files. > > I don't really agree with this one. If anything I think we should > slowly move to making the code insert a space between the `if` and > the open parenthesis because its easier to read. > > Erik