flac dev - Jan 2016 - Lets do a 1.3.2 release

Dave Yeo wrote:
> Seems that the default binutils on OS/2 is too old to support AVX2,
> attached patch works around this. Not the best solution as best would be
> configure tests, but simple.
Are you sure that these binutils support AVX and FMA? (Currently libFLAC
doesn't contain AVX and FMA instructions). If they aren't supported then
it's better to include them too into #if !defined __OS2__ ... #endif.

On 01/18/16 07:42 AM, lvqcl wrote:
> Dave Yeo wrote:
>
>> >Seems that the default binutils on OS/2 is too old to support AVX2,
>> >attached patch works around this. Not the best solution as best
would be
>> >configure tests, but simple.
> Are you sure that these binutils support AVX and FMA? (Currently libFLAC
> doesn't contain AVX and FMA instructions). If they aren't supported
then
> it's better to include them too into #if !defined __OS2__ ... #endif.
The nature of the error implies AVX2 support that is missing but I'm not 
much up on assembly,
make[4]: Entering directory `K:/usr/local/src/flac/src/libFLAC'
   CC       lpc_intrin_avx2.lo
R:/tmp/ccwvrScM.s: Assembler messages:
R:/tmp/ccwvrScM.s:495: Error: operand type mismatch for `vbroadcastss'
...
R:/tmp/ccwvrScM.s:8773: Error: operand type mismatch for `vpsrlq'
R:/tmp/ccwvrScM.s:8778: Error: no such instruction: `vpermd 
%ymm1,%ymm5,%ymm0'
R:/tmp/ccwvrScM.s:8859: Error: operand type mismatch for `vpmovzxdq'
...

Best to be safe so updated patch attached.
I've also opened a ticket, http://trac.netlabs.org/rpm/ticket/165#ticket
Dave
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-OS-2-currently-has-too-old-of-a-binutils-to-support-.patch
Type: application/x-patch
Size: 908 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/flac-dev/attachments/20160118/a93dd71a/attachment.bin

Dave Yeo wrote:
> The nature of the error implies AVX2 support that is missing but I'm
not
> much up on assembly,
>
> Best to be safe so updated patch attached.
> I've also opened a ticket,
http://trac.netlabs.org/rpm/ticket/165#ticket
> Dave
I cannot find information what version of binutils supports AVX/AVX2/FMA
instructions, but IIRC OS/2 doesn't support AVX instructions anyway,
so it doesn't matter much.