Martijn van Beurden
2014-Sep-22 20:08 UTC
[flac-dev] [PATCH] apodization for struct CompressionLevels
Op 22-09-14 om 21:56 schreef Erik de Castro Lopo:> Wouldn't "tukey(1/2)" be better? > > Erik5e-1 is directly parsed by strtod, while 1/2 isn't AFAIK.
Martijn van Beurden wrote:>> Wouldn't "tukey(1/2)" be better? >> >> Erik > > 5e-1 is directly parsed by strtod, while 1/2 isn't AFAIK.Another idea is to write flac_strtod() (and probably local_strtod() too) function that is able to parse both "0.5" and "0,5" strings regardless of current locale settings. But I'm not sure that this idea is good enough.
Erik de Castro Lopo
2014-Sep-22 21:00 UTC
[flac-dev] [PATCH] apodization for struct CompressionLevels
Martijn van Beurden wrote:> 5e-1 is directly parsed by strtod, while 1/2 isn't AFAIK.Ok, scratch my suggestion. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Janne Hyvärinen
2014-Sep-23 17:14 UTC
[flac-dev] [PATCH] apodization for struct CompressionLevels
On 22.9.2014 23:22, lvqcl wrote:> Martijn van Beurden wrote: > >>> Wouldn't "tukey(1/2)" be better? >>> >>> Erik >> 5e-1 is directly parsed by strtod, while 1/2 isn't AFAIK. > Another idea is to write flac_strtod() (and probably local_strtod() too) > function that is able to parse both "0.5" and "0,5" strings regardless of > current locale settings. But I'm not sure that this idea is good enough. >I have never understood why someone makes program input parameters depend on locale. The program shows parameters and help texts in international English and command line tools are meant to be scriptable. In my opinion a program is buggy if regular dot isn't accepted as decimal point. I'd welcome this change.