flac dev - Sep 2014 - [PATCH] apodization for struct CompressionLevels

Currently apodization function is hardcoded,
see commit
<http://git.xiph.org/?p=flac.git;a=commitdiff;h=4e8fe85bceb245dfce07d1956b144e1cb6587c9f>

FLAC is locale-dependent so "tukey(0.5)" doesn't work for locales
with decimal comma.

But "tukey(5e-1)" should be locale-independent so it is possible to
re-add 'const char *apodization' member into CompressionLevels struct.

The patch is attached.

This will allow to easily change preset settings from "tukey(5e-1)"
to "tukey(5e-1);partial_tukey(2);punchout_tukey(3)" or something like
this.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: apodization.patch
Type: application/octet-stream
Size: 2457 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/flac-dev/attachments/20140922/69feda2a/attachment-0001.obj

lvqcl wrote:
> FLAC is locale-dependent so "tukey(0.5)" doesn't work for
locales
> with decimal comma.

Wouldn't "tukey(1/2)" be better?

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/

Op 22-09-14 om 21:56 schreef Erik de Castro Lopo:
> Wouldn't "tukey(1/2)" be better?
>
> Erik
5e-1 is directly parsed by strtod, while 1/2 isn't AFAIK.

Hi all,

This patch hasn't been applied yet. It looks to me like it still 
applies though.

Op 22-09-14 om 17:18 schreef lvqcl:
> Currently apodization function is hardcoded,
> see commit 
>
<http://git.xiph.org/?p=flac.git;a=commitdiff;h=4e8fe85bceb245dfce07d1956b144e1cb6587c9f>
>
> FLAC is locale-dependent so "tukey(0.5)" doesn't work for
locales
> with decimal comma.
>
> But "tukey(5e-1)" should be locale-independent so it is 
> possible to
> re-add 'const char *apodization' member into CompressionLevels 
> struct.
>
> The patch is attached.
>
> This will allow to easily change preset settings from 
> "tukey(5e-1)"
> to "tukey(5e-1);partial_tukey(2);punchout_tukey(3)" or 
> something like this.
>
>
> _______________________________________________
> flac-dev mailing list
> flac-dev at xiph.org
> http://lists.xiph.org/mailman/listinfo/flac-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://lists.xiph.org/pipermail/flac-dev/attachments/20141013/eedc3da5/attachment.htm

Martijn van Beurden wrote:
> This patch hasn't been applied yet. It looks to me like it still 
> applies though.
Good catch. Applied now.

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/