Hi all, There's a typo in the conditional to check the exit condition in ascii_strcasecmp in share/utf8/charset.c. It checks for (!*s1 || !*s1) instead of (!*s1 || !*s2). Attached patch fixes this. Note that the typo did not affect the result of the function as the loop is exited before changing s1 or s2 anyway. The problem was found by cppcheck which is run automatically on the Debian sources. Results here: cppcheck.sourceforge.net/devinfo/daca2-cppcheck1.63/daca2.html Best regards, Robert -------------- next part -------------- A non-text attachment was scrubbed... Name: flac-1.3.0-charset.patch Type: text/x-patch Size: 390 bytes Desc: not available Url : lists.xiph.org/pipermail/flac-dev/attachments/20140202/112ba3be/attachment.bin
Robert Kausch wrote:> Hi all, > > There's a typo in the conditional to check the exit condition in > ascii_strcasecmp in share/utf8/charset.c. It checks for (!*s1 || !*s1) > instead of (!*s1 || !*s2). Attached patch fixes this. > > Note that the typo did not affect the result of the function as the loop > is exited before changing s1 or s2 anyway. > > The problem was found by cppcheck which is run automatically on the > Debian sources. Results here: > cppcheck.sourceforge.net/devinfo/daca2-cppcheck1.63/daca2.htmlGreat catch. Patch applied. Thanks. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo mega-nerd.com