similar to: PATCH: Fix typo in conditional

Hi Chris, et. al, I''ve recently come across cppcheck (static analyser for C code) and ran it on the current btrfs directory from Linus''s repo and it''s reported the following potential issues: linux-2.6$ cppcheck -q fs/btrfs/ [fs/btrfs/compression.c:343]: (error) Data is allocated but not initialized: cb [fs/btrfs/compression.c:583]: (error) Data is allocated but not

These are derived from the FreeBSD functions here: https://github.com/freebsd/freebsd/blob/master/sys/libkern/strcasecmp.c Thanks: Eric Blake. --- common/include/Makefile.am | 6 +++ common/include/ascii-ctype.h | 6 +++ common/include/ascii-string.h | 77 ++++++++++++++++++++++++++++ common/include/test-ascii-string.c | 79 +++++++++++++++++++++++++++++ server/main.c

So, I forwarded the request for highlighting trailing whitespaces to phabricator upstream (https://secure.phabricator.com/T11879), and upstream folks suggest we enable the Lint feature in Arcanist ( https://secure.phabricator.com/book/phabricator/article/arcanist_lint/). This will enforce the check when `arc diff` is run (reviewers wouldn't see the warnings though). There are two linters we

Hello there, I just ran the sourceforge tool cppcheck over the source code of the new Linux kernel 2.6.32.4 It said 1. [./btrfs/free-space-cache.c:600]: (style) Redundant condition. It is safe to deallocate a NULL pointer The source code is                 if (info->bitmap)                         kfree(info->bitmap); I agree with cppcheck. Suggest delete the if test. 2.

fedora comes with 1.75 so I used that. I also used some additional flags: cppcheck --enable=all --inconclusive --std=posix --force On Wed, Jan 18, 2017 at 11:36 PM, Erik de Castro Lopo <mle+la at mega-nerd.com> wrote: > Rosen Penev wrote: > >> src/libFLAC/bitreader.c | 4 ++-- >> src/libFLAC/bitwriter.c | 4 ++-- >> src/plugin_xmms/plugin.c |

Why isn’t it in the LLVM repo? > On Nov 16, 2016, at 7:44 AM, Johannes Doerfert <doerfert at cs.uni-saarland.de> wrote: > > We have a clang format based arcanist linter (and some others) in the > Polly repository. When arcanist is used to create a review, the linter > result is shown online. We also have an arcanist add-on to run the lit > tests and show their result in

The if() statement always evaluated to true. Detected by "cppcheck", not tested on real hardware. Signed-off-by: Thomas Jarosch <thomas.jarosch at intra2net.com> --- drivers/rhino.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/rhino.c b/drivers/rhino.c index ca66169..e478bcb 100644 --- a/drivers/rhino.c +++ b/drivers/rhino.c @@ -187,7 +187,7

Hello there, Offending source code is ????? if(? ( BattVoltage> 129 ) || ( BattVoltage < 144 ) ) Maybe swap || for && would be better. This problem I found by using cppcheck. It said [rhino.c:190]: (warning) Logical disjunction always evaluates to true: BattVoltage> 129 || BattVoltage < 144. Regards David Binderman

Credit goes to "cppcheck". Signed-off-by: Thomas Jarosch <thomas.jarosch at intra2net.com> --- drivers/mge-utalk.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/mge-utalk.c b/drivers/mge-utalk.c index c6114c7..616e2ad 100644 --- a/drivers/mge-utalk.c +++ b/drivers/mge-utalk.c @@ -465,7 +465,8 @@ void upsdrv_shutdown(void) { char

Credit goess to "cppcheck" Signed-off-by: Thomas Jarosch <thomas.jarosch at intra2net.com> --- drivers/usb-common.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb-common.c b/drivers/usb-common.c index e51f3cf..e459872 100644 --- a/drivers/usb-common.c +++ b/drivers/usb-common.c @@ -116,7 +116,7 @@ int USBNewExactMatcher(USBDeviceMatcher_t

Thomas Schmitt via Syslinux <syslinux at zytor.com> writes: > My best theory is still that SYSLINUX would have some C code > parts which allow the compilers to produce non-equivalent > machine code. > > I see complaints in the output of cppcheck 1.67, which could > match this criterium. Nice list, thanks! By then way there are known errors in the library code, too, see

Hello there, I just ran the static analysis checker "cppcheck" over the source code of icecast version 2.3.3 Amongst many other things, it said [log.c:301]: (warning) Logical conjunction always evaluates to false: log_id < 0 && log_id>= 25. Source code is ??? if (log_id < 0 && log_id>= LOG_MAXLOGS) ??????? return; Suggest replace && with ||.

Credit goes to "cppcheck" Signed-off-by: Thomas Jarosch <thomas.jarosch at intra2net.com> --- common/common.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/common/common.c b/common/common.c index f443cb7..e8004d7 100644 --- a/common/common.c +++ b/common/common.c @@ -244,6 +244,7 @@ int sendsignalfn(const char *pidfn, int sig) if (fgets(buf,

--- src/libFLAC/bitreader.c | 4 ++-- src/libFLAC/bitwriter.c | 4 ++-- src/plugin_xmms/plugin.c | 2 +- src/share/utf8/charset.c | 1 + src/test_libFLAC++/encoders.cpp | 8 ++++---- src/test_libFLAC/decoders.c | 4 ++-- src/test_libFLAC/encoders.c | 8 ++++---- 7 files changed, 16 insertions(+), 15 deletions(-) diff --git a/src/libFLAC/bitreader.c

The Wine development release 2.19 is now available. What's new in this release (see below for details): - Support for 32-bit float audio on Android. - Named pipes now fully handled by the Wine server. - Support for a new Microsoft root certificate. - More transform fixes in GdiPlus. - Some heap allocation optimizations. - Various bug fixes. The source is available from the

The Wine development release 1.7.30 is now available. What's new in this release (see below for details): - More support for fonts in DirectWrite. - Improved ATL thunk support. - A few more C runtime functions. - Regedit import/export fixes. - Various bug fixes. The source is available from the following locations: http://prdownloads.sourceforge.net/wine/wine-1.7.30.tar.bz2

Hi, Gene Cumm wrote: > > 3) It feels like this is a moving target where gcc keeps changing and > > different results get reported. Do we have indications that different versions of gcc5 cause different behavior on the same build and boot machines ? Ady wrote: > Since the issue is only present on specific > hardware / firmware, whatever might seem to "solve" the

On 11/14, Mehdi Amini via llvm-dev wrote: > Ideally I’d even really like to have a both checking for revision on > phab, clang-formatting them, and post a comment when there is a > mismatch :) I'd like that! -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 195 bytes Desc: Digital signature URL:

xcalc is a scientific calculator X11 client that can emulate a TI-30 or an HP-10C. This release fixes things that cause warnings from gcc or cppcheck, as well as assorted build system maintenance and tuneups. Alan Coopersmith (5): Fix misleading indentation in math.c Reword fall through comments to appease gcc -Wimplicit-fallthrough Update README for gitlab migration

> On Jul 10, 2015 5:29 PM, "poma via Syslinux" <syslinux at zytor.com> wrote: > > > The same as with the ISOLINUX, stable and git. > > Only this time has nothing to do with the menu. > > 1) EXTLINUX is no longer a discrete variant. The installer extlinux now > installs SYSLINUX. > 2) William Kensington already saw a similar behavior wherein an