On 10.4.2013 10:39, Martijn van Beurden wrote:> On 08-04-13 22:00, Janne Hyv?rinen wrote: >> On 8.4.2013 21:38, Janne Hyv?rinen wrote: >>> Friendly people on Hydrogenaudio found some bugs with the Unicode >>> printing code, so I was forced to make adjustments. >>> [...] >> The long line patch is broken and requires much more work, please >> ignore it. The other patch is still good. >> Here's a patch to get working Unicode support for one forgotten print >> function in metaflac. > I've just verified these patches (the UTF-8 ones, not the long line > patch) work for both MSVC as well as MinGW, basic tests > (FLAC__TEST_LEVEL = 0) passed. I tested the MSVC build by replacing the > binaries of a directory I did the MinGW build in with the MSVC binaries > and running the tests again. Handling filenames with Cyrillic and Greek > characters finally (fully) works here with these patches, which is great! > > I only got one warning, win_utf8_io.c:96:5: warning: no previous > prototype for 'print_console' > _______________________________________________ >Here's patch version 2 for long line printing bug. I installed latest xubuntu into a virtual machine and tested that at least graphical linux console handles the changes properly. -------------- next part -------------- A non-text attachment was scrubbed... Name: flac_patches_v2.zip Type: application/x-zip-compressed Size: 4147 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20130410/3040e97a/attachment.bin
On 10.4.2013 13:06, Janne Hyv?rinen wrote:> On 10.4.2013 10:39, Martijn van Beurden wrote: >> On 08-04-13 22:00, Janne Hyv?rinen wrote: >>> On 8.4.2013 21:38, Janne Hyv?rinen wrote: >>>> Friendly people on Hydrogenaudio found some bugs with the Unicode >>>> printing code, so I was forced to make adjustments. >>>> [...] >>> The long line patch is broken and requires much more work, please >>> ignore it. The other patch is still good. >>> Here's a patch to get working Unicode support for one forgotten print >>> function in metaflac. >> I've just verified these patches (the UTF-8 ones, not the long line >> patch) work for both MSVC as well as MinGW, basic tests >> (FLAC__TEST_LEVEL = 0) passed. I tested the MSVC build by replacing the >> binaries of a directory I did the MinGW build in with the MSVC binaries >> and running the tests again. Handling filenames with Cyrillic and Greek >> characters finally (fully) works here with these patches, which is >> great! >> >> I only got one warning, win_utf8_io.c:96:5: warning: no previous >> prototype for 'print_console' >> _______________________________________________ >> > > Here's patch version 2 for long line printing bug. I installed latest > xubuntu into a virtual machine and tested that at least graphical > linux console handles the changes properly. >Sorry for spamming but I noticed one more display glitch while doing further testing. It could leave old status messages at the end of the line while printing status messages if initial status fit on one line and new status text required new line. -------------- next part -------------- A non-text attachment was scrubbed... Name: flac_patches_v3.zip Type: application/x-zip-compressed Size: 4218 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20130410/8504a902/attachment-0001.bin
Janne Hyv?rinen wrote:> Sorry for spamming but I noticed one more display glitch while doing > further testing. It could leave old status messages at the end of the > line while printing status messages if initial status fit on one line > and new status text required new line.Patches applied. Thanks! Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/