--- Ben Hines <bhines@alumni.ucsd.edu> wrote:> That patch does get the .libs dir added to the compile line. But the > other problem is that libtool is attempting to link against the > installed version of libFLAC, that is $(DESTDIR)/lib/libFLAC.dylib > instead of -lFLAC. > > ... > > Not sure how to fix this one, but this HACK to ltmain.sh fixes this > problem. It just totally disables relinking, and does not seem to > have > any ill effects.OK, I see. Matt, are you having the same problem with the Debian package? If so, maybe I should conditionalize Ben's hack around the libxmms-flac build similar to how you did libtool-disable-static ? Josh __________________________________________________ Do You Yahoo!? Yahoo! - Official partner of 2002 FIFA World Cup http://fifaworldcup.yahoo.com
--- Ben Hines <bhines@alumni.ucsd.edu> wrote:> At 10:39 AM -0700 5/21/02, Josh Coalson wrote: > >--- Ben Hines <bhines@alumni.ucsd.edu> wrote: > >> I guess the problem is really why is it trying to relink it? > >> > >> The "parse error: condition expected:" is suspicious, though.. > maybe > >> it's another "zsh as sh" problem... hmm.. > > > >I don't remember having any trouble building the plugin on > >my ibook but that was a few months ago, so my memory may be > >fuzzy. I'll try again and post what I get. > > > I think the key is attempting to build it with a DESTDIR. Be sure you > > use a DESTDIR - and a prefix. :) > > I actually found some hints about this bug in libtool: > > "libtool 1.4.2 (gettext 0.11): Relinking fails when DESTDIR set" > > http://mail.gnu.org/pipermail/bug-libtool/2002-February/003018.html > http://mail.gnu.org/pipermail/libtool/2002-April/006244.html > http://mail.gnu.org/pipermail/libtool/2002-April/006250.html > > They have a patch to supposedly fix the bug. This patch works with > another package i was having problems with, but not FLAC. > http://mail.gnu.org/pipermail/libtool/2002-April/006268.html > http://mail.gnu.org/pipermail/bug-libtool/2002-February/003019.html > > > Also, FLAC needs the "The loadable module bug" libtool patch which is > > listed at this page: > http://fink.sourceforge.net/doc/porting/libtool.phpBen, I ran across a possible fix on another mailing list: http://lists.freshrpms.net/pipermail/rpm-list/2002-April/000746.html Try changing the libxmms_flac_la_LIBADD line in flac/src/plugin_xmms/Makefile.am to: libxmms_flac_la_LIBADD = $(top_builddir)/src/libFLAC/libFLAC.la -L$(top_builddir)/src/libFLAC/.libs @XMMS_LIBS@ If this works, let me know and I'll check it in. Josh __________________________________________________ Do You Yahoo!? Yahoo! - Official partner of 2002 FIFA World Cup http://fifaworldcup.yahoo.com
That patch does get the .libs dir added to the compile line. But the
other problem is that libtool is attempting to link against the
installed version of libFLAC, that is $(DESTDIR)/lib/libFLAC.dylib
instead of -lFLAC.
See:
cc -bundle -flat_namespace -undefined suppress -o .libs/libxmms-flac.so
plugin.lo -L/sw/lib /sw/lib/libFLAC.dylib
-L/sw/src/flac-1.0.2-1/flac-1.0.2/src/libFLAC/.libs -L/usr/X11R6/lib
/sw/lib/libgtk.dylib /sw/lib/libgdk.dylib /sw/lib/libgmodule.dylib
/sw/lib/libglib.dylib -ldl /sw/lib/libintl.dylib -lXext -lX11 -lm
/sw/lib/libxmms.dylib /sw/lib/libogg.dylib -lc -install_name
/sw/lib/xmms/Input/libxmms-flac.so
cc: /sw/lib/libFLAC.dylib: No such file or directory
libtool-disable-static: install: error: relink `libxmms-flac.la' with
the above command before installing it
libtool-disable-static: install: warning: remember to run
`libtool-disable-static --finish /sw/lib/xmms/Input'
Not sure how to fix this one, but this HACK to ltmain.sh fixes this
problem. It just totally disables relinking, and does not seem to have
any ill effects.
--- flac-1.0.2/ltmain.sh Mon Dec 3 23:10:14 2001
+++ flac-1.0.2-patched/ltmain.sh Wed Jun 26 01:06:54 2002
@@ -3948,10 +3952,10 @@
# Directory that this library needs to be installed in:
libdir='$install_libdir'"
- if test "$installed" = no && test $need_relink = yes; then
- $echo >> $output "\
-relink_command=\"$relink_command\""
- fi
+# if test "$installed" = no && test $need_relink = yes;
then
+# $echo >> $output "\
+#relink_command=\"$relink_command\""
+# fi
done
fi
Since this works fine for me, i'll add flac-1.0.2 to fink as soon as I
can. I probably should make separate packages for flac with and without
the xmms plugin, since with the xmms plugin flac will have to depend on
xmms which depends on xfree86.
-Ben