Facebooker talk - Jan 2008 - Facebooker and file_column

Facebooker URL Rewriter stuff overloads
ActionController::AbstractRequest.relative_url_root, causing a conflict with the
plugin file_column and possibly other utilities.  file_column constructs image
URLs using the server host and relative_url_root

This is not related to the sandbox patch I added to the rewriter.  Facebooker
overloaded relative_url_root before I touched it.

I''ve rewritten the facebooker_url_rewriting.rb script to do the same
stuff but without overloading relative_url_root.  I''ll send it in later
today.

Shawn

Shawn, that''s great. I think that is going to clean up a lot of our  
code. The asset path patches can go away at that point. I look forward  
to seeing this.

Mike

On Jan 31, 2008, at 2:30 PM, Shawn Van Ittersum wrote:
> Facebooker URL Rewriter stuff overloads  
> ActionController::AbstractRequest.relative_url_root, causing a  
> conflict with the plugin file_column and possibly other utilities.   
> file_column constructs image URLs using the server host and  
> relative_url_root
>
> This is not related to the sandbox patch I added to the rewriter.   
> Facebooker overloaded relative_url_root before I touched it.
>
> I''ve rewritten the facebooker_url_rewriting.rb script to do the
same
> stuff but without overloading relative_url_root.  I''ll send it in
> later today.
>
> Shawn
> _______________________________________________
> Facebooker-talk mailing list
> Facebooker-talk at rubyforge.org
> http://rubyforge.org/mailman/listinfo/facebooker-talk
--
Mike Mangino
http://www.elevatedrails.com

Okay, I have this working. We no longer need to set the relative url  
root to make Facebooker generate correct links.

With this setup, javascript_include_tag and stylesheet_link_tag work  
correctly as long as the asset host is set.

Please be careful with this release. All of the tests run, and it  
works on my apps, but it''s a major change. You''ll want to test
it well
before you use this in production.

Mike


On Jan 31, 2008, at 2:51 PM, Mike Mangino wrote:
> Shawn, that''s great. I think that is going to clean up a lot of
our
> code. The asset path patches can go away at that point. I look forward
> to seeing this.
>
> Mike
>
> On Jan 31, 2008, at 2:30 PM, Shawn Van Ittersum wrote:
>
>> Facebooker URL Rewriter stuff overloads
>> ActionController::AbstractRequest.relative_url_root, causing a
>> conflict with the plugin file_column and possibly other utilities.
>> file_column constructs image URLs using the server host and
>> relative_url_root
>>
>> This is not related to the sandbox patch I added to the rewriter.
>> Facebooker overloaded relative_url_root before I touched it.
>>
>> I''ve rewritten the facebooker_url_rewriting.rb script to do
the same
>> stuff but without overloading relative_url_root.  I''ll send it
in
>> later today.
>>
>> Shawn
>> _______________________________________________
>> Facebooker-talk mailing list
>> Facebooker-talk at rubyforge.org
>> http://rubyforge.org/mailman/listinfo/facebooker-talk
>
> --
> Mike Mangino
> http://www.elevatedrails.com
>
> _______________________________________________
> Facebooker-talk mailing list
> Facebooker-talk at rubyforge.org
> http://rubyforge.org/mailman/listinfo/facebooker-talk
--
Mike Mangino
http://www.elevatedrails.com