Facebooker talk - Jan 2008 - Is there a test for setting the session ID to the fb_sig_session_key param?

Hey all,

I have a patch that fixes a problem I am having with IFramed pages in
rails 2.0.   I am relying on the session being retrieved via
fb_sig_session_key.  I am looking for the test code that tests this
functionality but I can''t seem to find it.

So you on the list today Chad,  gotta pointer for me?


Thanks, I want to get a test in for this fix,

Dave

Hi Dave and others,

When making any changes to the way sessions are retrieved and validated, please
test them with forms in an FBML app.  In parsing FBML, Facebook adds fb_ params
in hidden inputs to POST forms.  These params messed up the rfacebook session
validation, which is why I''m here on Facebooker, since it
doesn''t have that problem. :)  Let''s be sure to keep it
working. :)

Thanks,
Shawn

On Thu, 24 Jan 2008 13:32:04 -0700, David Clements
wrote:
> Hey all,
> 
> I have a patch that fixes a problem I am having with IFramed pages in
> rails 2.0.   I am relying on the session being retrieved via
> fb_sig_session_key.  I am looking for the test code that tests this
> functionality but I can''t seem to find it.
> 
> So you on the list today Chad,  gotta pointer for me?
> 
> 
> Thanks, I want to get a test in for this fix,
> 
> Dave
> _______________________________________________
> Facebooker-talk mailing list
> Facebooker-talk at rubyforge.org
> http://rubyforge.org/mailman/listinfo/facebooker-talk

I think Michael wrote that code, and we decided that the tests would  
be more work than they are worth. Can you explain exactly what problem  
you are having?

Mike

On Jan 24, 2008, at 2:32 PM, David Clements wrote:
> Hey all,
>
> I have a patch that fixes a problem I am having with IFramed pages in
> rails 2.0.   I am relying on the session being retrieved via
> fb_sig_session_key.  I am looking for the test code that tests this
> functionality but I can''t seem to find it.
>
> So you on the list today Chad,  gotta pointer for me?
>
>
> Thanks, I want to get a test in for this fix,
>
> Dave
> _______________________________________________
> Facebooker-talk mailing list
> Facebooker-talk at rubyforge.org
> http://rubyforge.org/mailman/listinfo/facebooker-talk
--
Mike Mangino
http://www.elevatedrails.com

Hey Mike,

I just realized that you might run into the issue that this patch was
meant to fix, if you are working on sharing sessions between facebook
and web accesible parts of the app.  I was hoping that my patch
submission was clear enough but perhaps not.

Basic problem is that when hitting my app with an fb:iframe tag I do
not get my session setup properly.  This is because the session code
is only looking at request_parameters and not the query_parameters.
In this case the request_parameters were empty, since it is a GET
request.

IM me if that doesn''t make sense.  This issue only popped up for me
when we moved to rails 2.0.

Dave


On Jan 25, 2008 10:56 AM, Mike Mangino <mmangino at elevatedrails.com>
wrote:
> I think Michael wrote that code, and we decided that the tests would
> be more work than they are worth. Can you explain exactly what problem
> you are having?
>
> Mike
>
>
> On Jan 24, 2008, at 2:32 PM, David Clements wrote:
>
> > Hey all,
> >
> > I have a patch that fixes a problem I am having with IFramed pages in
> > rails 2.0.   I am relying on the session being retrieved via
> > fb_sig_session_key.  I am looking for the test code that tests this
> > functionality but I can''t seem to find it.
> >
> > So you on the list today Chad,  gotta pointer for me?
> >
> >
> > Thanks, I want to get a test in for this fix,
> >
> > Dave
>
> > _______________________________________________
> > Facebooker-talk mailing list
> > Facebooker-talk at rubyforge.org
> > http://rubyforge.org/mailman/listinfo/facebooker-talk
>
> --
> Mike Mangino
> http://www.elevatedrails.com
>
>
>
>

I hit that too. I have a fix for it locally that I will commit tonight.

Mike

On Jan 28, 2008, at 4:28 PM, David Clements wrote:
> Hey Mike,
>
> I just realized that you might run into the issue that this patch was
> meant to fix, if you are working on sharing sessions between facebook
> and web accesible parts of the app.  I was hoping that my patch
> submission was clear enough but perhaps not.
>
> Basic problem is that when hitting my app with an fb:iframe tag I do
> not get my session setup properly.  This is because the session code
> is only looking at request_parameters and not the query_parameters.
> In this case the request_parameters were empty, since it is a GET
> request.
>
> IM me if that doesn''t make sense.  This issue only popped up for
me
> when we moved to rails 2.0.
>
> Dave
>
>
> On Jan 25, 2008 10:56 AM, Mike Mangino <mmangino at
elevatedrails.com>
> wrote:
>> I think Michael wrote that code, and we decided that the tests would
>> be more work than they are worth. Can you explain exactly what  
>> problem
>> you are having?
>>
>> Mike
>>
>>
>> On Jan 24, 2008, at 2:32 PM, David Clements wrote:
>>
>>> Hey all,
>>>
>>> I have a patch that fixes a problem I am having with IFramed pages
>>> in
>>> rails 2.0.   I am relying on the session being retrieved via
>>> fb_sig_session_key.  I am looking for the test code that tests this
>>> functionality but I can''t seem to find it.
>>>
>>> So you on the list today Chad,  gotta pointer for me?
>>>
>>>
>>> Thanks, I want to get a test in for this fix,
>>>
>>> Dave
>>
>>> _______________________________________________
>>> Facebooker-talk mailing list
>>> Facebooker-talk at rubyforge.org
>>> http://rubyforge.org/mailman/listinfo/facebooker-talk
>>
>> --
>> Mike Mangino
>> http://www.elevatedrails.com
>>
>>
>>
>>
--
Mike Mangino
http://www.elevatedrails.com

Cool thanks,

I''ll verify and close out that patch if it solves my problem.
Hopefully you found it faster than me, I had too many variables going
on.

Dave

On Jan 28, 2008 3:45 PM, Mike Mangino <mmangino at elevatedrails.com>
wrote:
> I hit that too. I have a fix for it locally that I will commit tonight.
>
> Mike
>
>
> On Jan 28, 2008, at 4:28 PM, David Clements wrote:
>
> > Hey Mike,
> >
> > I just realized that you might run into the issue that this patch was
> > meant to fix, if you are working on sharing sessions between facebook
> > and web accesible parts of the app.  I was hoping that my patch
> > submission was clear enough but perhaps not.
> >
> > Basic problem is that when hitting my app with an fb:iframe tag I do
> > not get my session setup properly.  This is because the session code
> > is only looking at request_parameters and not the query_parameters.
> > In this case the request_parameters were empty, since it is a GET
> > request.
> >
> > IM me if that doesn''t make sense.  This issue only popped up
for me
> > when we moved to rails 2.0.
> >
> > Dave
> >
> >
> > On Jan 25, 2008 10:56 AM, Mike Mangino <mmangino at
elevatedrails.com>
> > wrote:
> >> I think Michael wrote that code, and we decided that the tests
would
> >> be more work than they are worth. Can you explain exactly what
> >> problem
> >> you are having?
> >>
> >> Mike
> >>
> >>
> >> On Jan 24, 2008, at 2:32 PM, David Clements wrote:
> >>
> >>> Hey all,
> >>>
> >>> I have a patch that fixes a problem I am having with IFramed
pages
> >>> in
> >>> rails 2.0.   I am relying on the session being retrieved via
> >>> fb_sig_session_key.  I am looking for the test code that tests
this
> >>> functionality but I can''t seem to find it.
> >>>
> >>> So you on the list today Chad,  gotta pointer for me?
> >>>
> >>>
> >>> Thanks, I want to get a test in for this fix,
> >>>
> >>> Dave
> >>
> >>> _______________________________________________
> >>> Facebooker-talk mailing list
> >>> Facebooker-talk at rubyforge.org
> >>> http://rubyforge.org/mailman/listinfo/facebooker-talk
> >>
> >> --
> >> Mike Mangino
> >> http://www.elevatedrails.com
> >>
> >>
> >>
> >>
>
> --
> Mike Mangino
> http://www.elevatedrails.com
>
> _______________________________________________
> Facebooker-talk mailing list
> Facebooker-talk at rubyforge.org
> http://rubyforge.org/mailman/listinfo/facebooker-talk
>