Facebooker talk - Nov 2007 - Some proposed changes

I''ve got some changes queued up that I want to run by everyone before  
I commit.

First, I''ve added a filter that sets the :format variable to
"fbml"
when you are in the canvas view. That means with edge rails you can  
use index.fbml.erb for facebook and index.html.erb for non facebook  
requests and the right thing will happen. This is important for doing  
things with OpenSocial (which is IFrame based.)

I also modified init.rb to include Facebooker::Rails::Controller in  
subclasses of ActionController::Base. Without this change, redirect_to  
is defined in the wrong place and is too far back in the ancestors  
change to ever get used. This makes facebooker usable out of the box  
for me. My controller now looks like:


class ApplicationController < ActionController::Base
   session :off
   ensure_application_is_installed_by_facebook_user
end

Does anyone object to these changes? The format change could cause  
issues for people on edge, but is he right thing IMHO.

Mike

--
Mike Mangino
http://www.elevatedrails.com

On Nov 2, 2007, at 12:58 PM, Mike Mangino <mmangino at elevatedrails.com>
wrote:
> I''ve got some changes queued up that I want to run by everyone
before
> I commit.
>
> First, I''ve added a filter that sets the :format variable to
"fbml"
> when you are in the canvas view. That means with edge rails you can
> use index.fbml.erb for facebook and index.html.erb for non facebook
> requests and the right thing will happen. This is important for doing
> things with OpenSocial (which is IFrame based.)
>
> I also modified init.rb to include Facebooker::Rails::Controller in
> subclasses of ActionController::Base. Without this change, redirect_to
> is defined in the wrong place and is too far back in the ancestors
> change to ever get used. This makes facebooker usable out of the box
> for me. My controller now looks like:
>
>
> class ApplicationController < ActionController::Base
>   session :off
>   ensure_application_is_installed_by_facebook_user
> end
>
> Does anyone object to these changes? The format change could cause
> issues for people on edge, but is he right thing IMHO
>

I agree on both of them.


Chad

> -
> _______________________________________________
> Facebooker-talk mailing list
> Facebooker-talk at rubyforge.org
> http://rubyforge.org/mailman/listinfo/facebooker-talk