On 2 Apr 2019, at 22.37, Timo Sirainen via dovecot <dovecot at dovecot.org> wrote:> > On 2 Apr 2019, at 17.03, Jan-Pieter Cornet via dovecot <dovecot at dovecot.org <mailto:dovecot at dovecot.org>> wrote: >> >> Hi, >> >> We're synching mailboxes, changing format from maildir to mdbox, using doveadm backup/doveadm sync. >> >> When still running 2.2.36, 'doveadm backup' also synched the sieve scripts, without issues. >> >> After the upgrade to 2.3.5.1, the sieve sync stopped working. We're using the pre-built 2.3 packages from https://repo.dovecot.org/ce-2.3-latest/debian/stretch <https://repo.dovecot.org/ce-2.3-latest/debian/stretch> > > Looks like this is trivial to reproduce. It used to work still in v2.3.1, but then something broke it. Tracking internally in DOP-1062.Reverting https://github.com/dovecot/pigeonhole/commit/479c5e57046dec76078597df844daccbfc0eb75f <https://github.com/dovecot/pigeonhole/commit/479c5e57046dec76078597df844daccbfc0eb75f> fixes this. -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://dovecot.org/pipermail/dovecot/attachments/20190402/6f824a4b/attachment-0001.html>
Timo Sirainen via dovecot wrote:> On 2 Apr 2019, at 22.37, Timo Sirainen via dovecot <dovecot at dovecot.org > <mailto:dovecot at dovecot.org>> wrote: >> >> On 2 Apr 2019, at 17.03, Jan-Pieter Cornet via dovecot >> <dovecot at dovecot.org <mailto:dovecot at dovecot.org>> wrote: >>> >>> Hi, >>> >>> We're synching mailboxes, changing format from maildir to mdbox, >>> using doveadm backup/doveadm sync. >>> >>> When still running 2.2.36, 'doveadm backup' also synched the sieve >>> scripts, without issues. >>> >>> After the upgrade to 2.3.5.1, the sieve sync stopped working. We're >>> using the pre-built 2.3 packages from >>> https://repo.dovecot.org/ce-2.3-latest/debian/stretch >> >> Looks like this is trivial to reproduce. It used to work still in >> v2.3.1, but then something broke it. Tracking internally in DOP-1062. > > Reverting > https://github.com/dovecot/pigeonhole/commit/479c5e57046dec76078597df844daccbfc0eb75f?fixes > this. >This is a change where strncmp() gets replaced by str_begins(). IMO a good change, however in src/lib-sieve/storage/file/sieve-file-storage-save.c strncmp(scriptname, fstorage->active_fname, namelen) gets replaced by str_begins(fstorage->active_fname, scriptname) Note that the arguments are swapped here, giving a false result. Marc
On 2-4-19 21:51, Timo Sirainen via dovecot wrote:>> Looks like this is trivial to reproduce. It used to work still in v2.3.1, but then something broke it. Tracking internally in DOP-1062. > > Reverting https://github.com/dovecot/pigeonhole/commit/479c5e57046dec76078597df844daccbfc0eb75f?fixes this.Looks like that last patch segments puts the arguments to str_begin in the wrong order... strncmp(prefix, MAILBOX_ATTRIBUTE_PREFIX_SIEVE, strlen(prefix)) == 0 should be translated to: str_begins(MAILBOX_ATTRIBUTE_PREFIX_SIEVE, prefix) -- Jan-Pieter Cornet <johnpc at xs4all.net> Systeembeheer XS4ALL Internet bv www.xs4all.nl -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 963 bytes Desc: OpenPGP digital signature URL: <https://dovecot.org/pipermail/dovecot/attachments/20190403/abf1e8b5/attachment.sig>
Hello, Am 02.04.19 um 21:51 schrieb Timo Sirainen via dovecot:> On 2 Apr 2019, at 22.37, Timo Sirainen via dovecot <dovecot at dovecot.org > <mailto:dovecot at dovecot.org>> wrote: >> >> On 2 Apr 2019, at 17.03, Jan-Pieter Cornet via dovecot >> <dovecot at dovecot.org <mailto:dovecot at dovecot.org>> wrote: >>> >>> Hi, >>> >>> We're synching mailboxes, changing format from maildir to mdbox, >>> using doveadm backup/doveadm sync. >>> >>> When still running 2.2.36, 'doveadm backup' also synched the sieve >>> scripts, without issues. >>> >>> After the upgrade to 2.3.5.1, the sieve sync stopped working. We're >>> using the pre-built 2.3 packages from >>> https://repo.dovecot.org/ce-2.3-latest/debian/stretch >> >> Looks like this is trivial to reproduce. It used to work still in >> v2.3.1, but then something broke it. Tracking internally in DOP-1062. > > Reverting?https://github.com/dovecot/pigeonhole/commit/479c5e57046dec76078597df844daccbfc0eb75f?fixes > this. >has this been fixed in 2.3.6 ? In my first tests sieve scripts still seem not to be replicated with dovecot-2.3.6 Regards, Andreas -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 5394 bytes Desc: S/MIME Cryptographic Signature URL: <https://dovecot.org/pipermail/dovecot/attachments/20190503/58ecc630/attachment.p7s>
Hi, same here, this doesn't seeem to be fixed with latest pigeonhole and dovecot release. Regards, Marcel Am 03.05.2019 um 08:20 schrieb Piper Andreas via dovecot:> Hello, > > Am 02.04.19 um 21:51 schrieb Timo Sirainen via dovecot: >> On 2 Apr 2019, at 22.37, Timo Sirainen via dovecot <dovecot at dovecot.org >> <mailto:dovecot at dovecot.org>> wrote: >>> On 2 Apr 2019, at 17.03, Jan-Pieter Cornet via dovecot >>> <dovecot at dovecot.org <mailto:dovecot at dovecot.org>> wrote: >>>> Hi, >>>> >>>> We're synching mailboxes, changing format from maildir to mdbox, >>>> using doveadm backup/doveadm sync. >>>> >>>> When still running 2.2.36, 'doveadm backup' also synched the sieve >>>> scripts, without issues. >>>> >>>> After the upgrade to 2.3.5.1, the sieve sync stopped working. We're >>>> using the pre-built 2.3 packages from >>>> https://repo.dovecot.org/ce-2.3-latest/debian/stretch >>> Looks like this is trivial to reproduce. It used to work still in >>> v2.3.1, but then something broke it. Tracking internally in DOP-1062. >> Reverting?https://github.com/dovecot/pigeonhole/commit/479c5e57046dec76078597df844daccbfc0eb75f?fixes >> this. >> > has this been fixed in 2.3.6 ? > > In my first tests sieve scripts still seem not to be replicated with > dovecot-2.3.6 > > Regards, > Andreas >-------------- next part -------------- An HTML attachment was scrubbed... URL: <https://dovecot.org/pipermail/dovecot/attachments/20190504/0b2a7121/attachment.html>