dovecot - Mar 2019 - flags not synced correctly with dovecot sync (dsync)

In another thread, Timo wrote:

On Mar 12, 2019, Timo Sirainen via dovecot <dovecot at dovecot.org> wrote:
> That bug is fixed with attached patch.
Thanks!  I'm attaching the patch here, so it is in this thread as well.

A couple of questions before I test this:

- Do I need the patch on the remote end of the sync, or the local end,
  or both?

- Does it make sense to try it based on the master-2.3 branch from git?
  Following https://wiki.dovecot.org/CompilingSource  ?

I'll report back once I've tested it.

Dan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2656.patch
Type: text/x-diff
Size: 1225 bytes
Desc: not available
URL:
<https://dovecot.org/pipermail/dovecot/attachments/20190312/e3ea33fb/attachment.bin>

On Mar 12, 2019, Dan Christensen via dovecot <dovecot at dovecot.org>
wrote:
> In another thread, Timo wrote:
>
> On Mar 12, 2019, Timo Sirainen via dovecot <dovecot at dovecot.org>
wrote:
>
>> That bug is fixed with attached patch.
> 
> I'll report back once I've tested it.
I applied 2656.patch to version 2.3.5 as found at

  https://repo.dovecot.org/ce-2.3-latest/ubuntu/bionic/pool/main/2.3.5-1_ce/

and rebuilt the ubuntu package.  I installed the resulting package on
all three machines.  And still I can reproduce the bug involving unread
messages getting marked as read.

Dan

On 13 Mar 2019, at 22.43, Dan Christensen via dovecot <dovecot at
dovecot.org> wrote:
> 
> On Mar 12, 2019, Dan Christensen via dovecot <dovecot at dovecot.org>
wrote:
> 
>> In another thread, Timo wrote:
>> 
>> On Mar 12, 2019, Timo Sirainen via dovecot <dovecot at
dovecot.org> wrote:
>> 
>>> That bug is fixed with attached patch.
>> 
>> I'll report back once I've tested it.
> 
> I applied 2656.patch to version 2.3.5 as found at
> 
>  https://repo.dovecot.org/ce-2.3-latest/ubuntu/bionic/pool/main/2.3.5-1_ce/
> 
> and rebuilt the ubuntu package.  I installed the resulting package on
> all three machines.  And still I can reproduce the bug involving unread
> messages getting marked as read.
Looks like you're also using Maildir, which has another bug of keywords not
being copied correctly.