dovecot - Sep 2018 - Auth process sometimes stop responding after upgrade

On 19 Sep 2018, at 11.30, Timo Sirainen <tss at iki.fi>
wrote:
> 
>> 
>> On 19 Sep 2018, at 11.11, Simone Lazzaris <s.lazzaris at
interactive.eu <mailto:s.lazzaris at interactive.eu>> wrote:
>> 
>> In data mercoled? 19 settembre 2018 09:30:47 CEST, Timo Sirainen ha
scritto:
>> > On 18 Sep 2018, at 15.15, Simone Lazzaris <s.lazzaris at
interactive.eu <mailto:s.lazzaris at interactive.eu>> wrote:
>> > > I've got a core dump, and here is the backtrace. Let me
know if you want
>> > > the core file.
>> > It would be useful if we're able to use it. Could you use
>> > https://dovecot.org/tools/core-tar.sh
<https://dovecot.org/tools/core-tar.sh>
>> > <https://dovecot.org/tools/core-tar.sh
<https://dovecot.org/tools/core-tar.sh>> to send the core and the
related
>> > binaries (e.g. just email to me)? The usage is explained at the
beginning
>> > of the script. At least in theory we could then debug with the
core file,
>> > although I've had some trouble even then.
>> > 
>> > But just in case the core doesn't work, could you also do:
>> > 
>> > bt full
>> > fr 8
>> > p *((struct doveadm_connection *)io->context)
>> > p *((struct doveadm_connection *)io->context)->input
>>  
>> I'm sending you the tarball created with core-tar; and just in
case:
> 
> Thanks, the core worked fine. Does the attached patch (on top of the
previous one) help?
> 
> <director.diff>
Or here's a slightly different patch, although it should be basically the
same fix. This includes the previous patch as well.



-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://dovecot.org/pipermail/dovecot/attachments/20180919/73fd0fb5/attachment-0002.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: director2.diff
Type: application/octet-stream
Size: 2503 bytes
Desc: not available
URL:
<https://dovecot.org/pipermail/dovecot/attachments/20180919/73fd0fb5/attachment-0001.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://dovecot.org/pipermail/dovecot/attachments/20180919/73fd0fb5/attachment-0003.html>

On 19 Sep 2018, at 11.42, Timo Sirainen <tss at iki.fi>
wrote:
> 
> On 19 Sep 2018, at 11.30, Timo Sirainen <tss at iki.fi <mailto:tss at
iki.fi>> wrote:
>> 
>>> 
>>> On 19 Sep 2018, at 11.11, Simone Lazzaris <s.lazzaris at
interactive.eu <mailto:s.lazzaris at interactive.eu>> wrote:
>>> 
>>> In data mercoled? 19 settembre 2018 09:30:47 CEST, Timo Sirainen ha
scritto:
>>> > On 18 Sep 2018, at 15.15, Simone Lazzaris <s.lazzaris at
interactive.eu <mailto:s.lazzaris at interactive.eu>> wrote:
>>> > > I've got a core dump, and here is the backtrace. Let
me know if you want
>>> > > the core file.
>>> > It would be useful if we're able to use it. Could you use
>>> > https://dovecot.org/tools/core-tar.sh
<https://dovecot.org/tools/core-tar.sh>
>>> > <https://dovecot.org/tools/core-tar.sh
<https://dovecot.org/tools/core-tar.sh>> to send the core and the
related
>>> > binaries (e.g. just email to me)? The usage is explained at
the beginning
>>> > of the script. At least in theory we could then debug with the
core file,
>>> > although I've had some trouble even then.
>>> > 
>>> > But just in case the core doesn't work, could you also do:
>>> > 
>>> > bt full
>>> > fr 8
>>> > p *((struct doveadm_connection *)io->context)
>>> > p *((struct doveadm_connection *)io->context)->input
>>>  
>>> I'm sending you the tarball created with core-tar; and just in
case:
>> 
>> Thanks, the core worked fine. Does the attached patch (on top of the
previous one) help?
>> 
>> <director.diff>
> 
> Or here's a slightly different patch, although it should be basically
the same fix. This includes the previous patch as well.
> 
> <director2.diff>
No, forget about that patch. Looks like I forgot I had already fixed this crash,
and I guess I was testing with master mainly, which is why I wasn't able to
reproduce the crash now:
https://github.com/dovecot/core/commit/c0583917fe760b2d901acf83387cc8edb6f99550
<https://github.com/dovecot/core/commit/c0583917fe760b2d901acf83387cc8edb6f99550>

-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://dovecot.org/pipermail/dovecot/attachments/20180919/bf5c22e1/attachment.html>

> No, forget about that patch. Looks like I forgot I had already fixed this
> crash, and I guess I was testing with master mainly, which is why I
wasn't
> able to reproduce the crash now:
> https://github.com/dovecot/core/commit/c0583917fe760b2d901acf83387cc8edb6f9
> 9550
>
<https://github.com/dovecot/core/commit/c0583917fe760b2d901acf83387cc8edb6f
> 99550>
You nailed it!

I've applied the fix from commit c058 and that solved the issue. I'm no
longer able to crash
the director by stopping/starting a backend.



*Simone Lazzaris*
*Qcom S.p.A.*
simone.lazzaris at qcom.it[1] | www.qcom.it[2]
* LinkedIn[3]* | *Facebook[4]*
[5] 






--------
[1] mailto:simone.lazzaris at qcom.it
[2] https://www.qcom.it
[3] https://www.linkedin.com/company/qcom-spa
[4] http://www.facebook.com/qcomspa
[5] https://www.qcom.it/includes/email-banner.gif
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://dovecot.org/pipermail/dovecot/attachments/20180919/0587f2c7/attachment.html>