dovecot - Feb 2017 - v2.2.28: patches (to use libressl 2.4.5) and test error (strftime)

t_strftime and variants now .......................................... : ok


test-time-util.c:123: Assert failed: strcmp(t_strftime(RFC2822_FMT,
gmtime(&ts)), exp) == 0


test-time-util.c:124: Assert failed: strcmp(t_strfgmtime(RFC2822_FMT, ts), exp)
== 0


t_strftime and variants fixed timestamp .............................. : FAILED


timings 0 ............................................................ : ok
-------------- next part --------------
A non-text attachment was scrubbed...
Name: configure.ac.patch
Type: application/octet-stream
Size: 842 bytes
Desc: not available
URL:
<http://dovecot.org/pipermail/dovecot/attachments/20170225/7994554c/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dcrypt-openssl.c.patch
Type: application/octet-stream
Size: 2777 bytes
Desc: not available
URL:
<http://dovecot.org/pipermail/dovecot/attachments/20170225/7994554c/attachment-0003.obj>

On 25 Feb 2017, at 21.11, Ruga <ruga at protonmail.com>
wrote:
> 
> t_strftime and variants now .......................................... : ok
> 
> 
> test-time-util.c:123: Assert failed: strcmp(t_strftime(RFC2822_FMT,
gmtime(&ts)), exp) == 0
> 
> 
> test-time-util.c:124: Assert failed: strcmp(t_strfgmtime(RFC2822_FMT, ts),
exp) == 0
> 
> 
> t_strftime and variants fixed timestamp .............................. :
FAILED
What OS is this? Could you try with the attached patch what it logs?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: diff
Type: application/octet-stream
Size: 554 bytes
Desc: not available
URL:
<http://dovecot.org/pipermail/dovecot/attachments/20170225/54cefbb8/attachment.obj>
-------------- next part --------------

> <configure.ac.patch>
Why do you want to disable /dev/urandom?
> <dcrypt-openssl.c.patch>
Oh, I forgot to remove the #if OPENSSL_VERSION_NUMBER checks from lib-dcrypt.
Will be removed in v2.2.29. Attached the planned patch that should do it.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: openssl.diff
Type: application/octet-stream
Size: 6263 bytes
Desc: not available
URL:
<http://dovecot.org/pipermail/dovecot/attachments/20170225/54cefbb8/attachment-0001.obj>

On 25 Feb 2017, at 21.54, Timo Sirainen <tss at iki.fi>
wrote:
> 
> Oh, I forgot to remove the #if OPENSSL_VERSION_NUMBER checks from
lib-dcrypt. Will be removed in v2.2.29. Attached the planned patch that should
do it.
Well that didn't work with <v1.1. Maybe this one.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: openssl.diff
Type: application/octet-stream
Size: 6744 bytes
Desc: not available
URL:
<http://dovecot.org/pipermail/dovecot/attachments/20170225/1d8aa63b/attachment.obj>

Timo,

re: What OS is this?
OS 10.12.3 with Xcode 8.2.1 and the official clang 3.9.0

re: test-time-util.c


t_strftime and variants now .......................................... : ok


Info: 'Thu, 08 Dec 2016 18:42:16 +0100'


test-time-util.c:124: Assert failed: strcmp(t_strftime(RFC2822_FMT,
gmtime(&ts)), exp) == 0


Info: 'Thu, 08 Dec 2016 18:42:16 +0100'


test-time-util.c:126: Assert failed: strcmp(t_strfgmtime(RFC2822_FMT, ts), exp)
== 0


t_strftime and variants fixed timestamp .............................. : FAILED


timings 0 ............................................................ : ok


re: Why do you want to disable /dev/urandom?
https://github.com/libressl-portable/portable/issues/278

re: dcrypt-openssl.c, ssl.m4 and HMAC_CTX_free(NULL)
Please discuss this with busterb at GitHub.








-------- Original Message --------
Subject: Re: v2.2.28: patches (to use libressl 2.4.5) and test error (strftime)
Local Time: 25 February 2017 8:54 PM
UTC Time: 25 February 2017 19:54
From: tss at iki.fi
To: Ruga <ruga at protonmail.com>
Dovecot Mailing List <dovecot at dovecot.org>

On 25 Feb 2017, at 21.11, Ruga <ruga at protonmail.com>
wrote:
>
> t_strftime and variants now .......................................... : ok
>
>
> test-time-util.c:123: Assert failed: strcmp(t_strftime(RFC2822_FMT,
gmtime(&ts)), exp) == 0
>
>
> test-time-util.c:124: Assert failed: strcmp(t_strfgmtime(RFC2822_FMT, ts),
exp) == 0
>
>
> t_strftime and variants fixed timestamp .............................. :
FAILED
What OS is this? Could you try with the attached patch what it logs?


> <configure.ac.patch>
Why do you want to disable /dev/urandom?
> <dcrypt-openssl.c.patch>
Oh, I forgot to remove the #if OPENSSL_VERSION_NUMBER checks from lib-dcrypt.
Will be removed in v2.2.29. Attached the planned patch that should do it.