On 12 Mar 2015, at 21:09, Reindl Harald <h.reindl at thelounge.net> wrote:> > /usr/lib64/dovecot/stats/libstats_mail.so > > why in the world a new sub-directory containing just one so-file enforcing pakcage buildsers to change SPEC files?So that external plugins can add more files in there and extend the available statistics.
Am 13.03.2015 um 11:23 schrieb Timo Sirainen:> On 12 Mar 2015, at 21:09, Reindl Harald <h.reindl at thelounge.net> wrote: >> >> /usr/lib64/dovecot/stats/libstats_mail.so >> >> why in the world a new sub-directory containing just one so-file enforcing pakcage buildsers to change SPEC files? > > So that external plugins can add more files in there and extend the available statisticsbut they can also go to /usr/lib64/dovecot/ http://fedoraproject.org/wiki/Packaging:Guidelines#Beware_of_Rpath hence cat /etc/ld.so.conf.d/dovecot-x86_64.conf /usr/lib64/dovecot i just "rm -rf" the folder and other stuff for private builds in environments where dovecot is running only as proxy rm -rf %{buildroot}%{_sysconfdir}/%{name}/README \ %{buildroot}%{_docdir}/%{name}-%{version} \ %{buildroot}%{_includedir}/%{name}/ \ %{buildroot}%{_mandir}/man1/ \ %{buildroot}%{_mandir}/man7/ \ %{buildroot}%{_datarootdir}/aclocal/ \ %{buildroot}%{_bindir}/dsync \ %{buildroot}%{_libdir}/%{name}/*_plugin.so \ %{buildroot}%{_libdir}/%{name}/doveadm/*_plugin.so \ %{buildroot}%{_libdir}/%{name}/lib%{name}-lda.so \ %{buildroot}%{_libdir}/%{name}/lib%{name}-lda.so.0 \ %{buildroot}%{_libdir}/%{name}/lib%{name}-lda.so.0.0.0 \ %{buildroot}%{_libdir}/%{name}/lib%{name}-compression.so \ %{buildroot}%{_libdir}/%{name}/lib%{name}-compression.so.0 \ %{buildroot}%{_libdir}/%{name}/lib%{name}-compression.so.0.0.0 \ %{buildroot}%{_libdir}/%{name}/stats \ %{buildroot}%{_libexecdir}/%{name}/%{name}-lda \ %{buildroot}%{_libexecdir}/%{name}/gdbhelper \ %{buildroot}%{_libexecdir}/%{name}/quota-status \ %{buildroot}%{_libexecdir}/%{name}/deliver \ %{buildroot}%{_libexecdir}/%{name}/lmtp -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 181 bytes Desc: OpenPGP digital signature URL: <http://dovecot.org/pipermail/dovecot/attachments/20150313/72a64014/attachment.sig>
On 13 Mar 2015, at 12:34, Reindl Harald <h.reindl at thelounge.net> wrote:> > > Am 13.03.2015 um 11:23 schrieb Timo Sirainen: >> On 12 Mar 2015, at 21:09, Reindl Harald <h.reindl at thelounge.net> wrote: >>> >>> /usr/lib64/dovecot/stats/libstats_mail.so >>> >>> why in the world a new sub-directory containing just one so-file enforcing pakcage buildsers to change SPEC files? >> >> So that external plugins can add more files in there and extend the available statistics > > but they can also go to /usr/lib64/dovecot/ > http://fedoraproject.org/wiki/Packaging:Guidelines#Beware_of_RpathThese are plugins, not libraries. They don't need rpaths. The reason for the new directory's existence is exactly the same as for the already existing plugin directories: $lib/dovecot/auth/ $lib/dovecot/doveadm/ $lib/dovecot/settings/ $lib/dovecot/sieve/ So auth, doveadm, settings and sieve all work by loading all the plugins from inside the directories. If I changed the stats to work differently, e.g. load $lib/dovecot/libstats_*.so it would work differently than everything else, which would be confusing. For consistency it would be better then to get rid of the above directories as well. But changing that would break backwards compatibility with external plugins (e.g. with Sieve).