Emmanuel Dreyfus
2013-Apr-11 08:41 UTC
[Dovecot] [PATCHES] NetBSD support, authentication buffer size
Hi Here are a few unintegrated patches, just tested against 2.2rc7: 1) NetBSD's getmntinfo uses struct statvfs while other BSD use struct statfs http://ftp.espci.fr/shadow/manu/patch-ak 2) NetBSD 5.x net_getunixcred() support. Build on NetBSD, but not tested (I am testing on NetBSD 6.0): http://ftp.espci.fr/shadow/manu/patch-src_lib_net.c 3) Increase authentication buffer size so that it can cope with unusual authentication scheme. This patch was integrated in dovecot-1.x but did not make its way in dovecot-2.x http://ftp.espci.fr/shadow/manu/patch-src_lib-master_master-auth.h -- Emmanuel Dreyfus manu at netbsd.org
Timo Sirainen
2013-Apr-11 09:28 UTC
[Dovecot] [PATCHES] NetBSD support, authentication buffer size
On 11.4.2013, at 11.41, Emmanuel Dreyfus <manu at netbsd.org> wrote:> Here are a few unintegrated patches, just tested against 2.2rc7: > > 1) NetBSD's getmntinfo uses struct statvfs while other BSD use struct statfs > http://ftp.espci.fr/shadow/manu/patch-ak > > 2) NetBSD 5.x net_getunixcred() support. Build on NetBSD, but not tested > (I am testing on NetBSD 6.0): > http://ftp.espci.fr/shadow/manu/patch-src_lib_net.cOK, I'll add these.> 3) Increase authentication buffer size so that it can cope with > unusual authentication scheme. This patch was integrated in dovecot-1.x > but did not make its way in dovecot-2.x > http://ftp.espci.fr/shadow/manu/patch-src_lib-master_master-auth.hBy this I think you don't mean special authentication mechanisms, or even AUTHENTICATE PLAIN mechanism, but you mean that someone is using LOGIN command in such a kludgy way that the password field is over 1024 bytes long? I'm not very interested in supporting that, at least without a good reason.
Emmanuel Dreyfus
2013-Apr-11 15:41 UTC
[Dovecot] [PATCHES] NetBSD support, authentication buffer size
On Thu, Apr 11, 2013 at 12:57:45PM +0000, Emmanuel Dreyfus wrote:> Perhaps [MASTER_AUTH_MAX_DATA_SIZE] could be configurable?I tried to add a configuration option for that, but dovecot design makes a good job at separating master and login structures, hence The Right Way is not obvious. Anu suggestion? -- Emmanuel Dreyfus manu at netbsd.org