dovecot - Feb 2010 - dovecot-2.0.beta3 tcpwrapper support in Solaris

Hi,

2.0 compiles fine in Solaris but and I've found only one glitch so far. 
  Tcpwapper support needs some tweaks.  I need to add 
CPPFLAGS=/usr/sfw/include  because tcpd.h is in there.  Then also
LDFLAGS='-R/usr/sfw/lib -L/usr/sfw/lib' is needed.  It would be nice to 
have --with-tcpwrap-dir or something.

After this linking gives an error
Undefined first referenced symbol in file
deny_severity /usr/sfw/lib//libwrap.so
allow_severity /usr/sfw/lib//libwrap.so

These are not defined but application itself should define these 
globally so I've added these to configure and src/util/tcpwrap.c
#include <syslog.h>
int allow_severity = LOG_INFO;
int deny_severity = LOG_WARNING;


   Tomppa

On Thu, 2010-02-25 at 13:30 +0200, Tomi Vainio wrote:
> Hi,
> 
> 2.0 compiles fine in Solaris but and I've found only one glitch so far.
>   Tcpwapper support needs some tweaks.  I need to add 
> CPPFLAGS=/usr/sfw/include  because tcpd.h is in there.  Then also
> LDFLAGS='-R/usr/sfw/lib -L/usr/sfw/lib' is needed.  It would be
nice to
> have --with-tcpwrap-dir or something.
I've generally avoided adding any --with-something=paths, since all of
them can be done with those CPPFLAGS/LDFLAGS changes. And with other
software that has them, I'm usually just more confused about what I
should give them as the path. Sometimes they work as I guessed,
sometimes not..
> These are not defined but application itself should define these 
> globally so I've added these to configure and src/util/tcpwrap.c
> #include <syslog.h>
> int allow_severity = LOG_INFO;
> int deny_severity = LOG_WARNING;
Added: http://hg.dovecot.org/dovecot-2.0/rev/0d17bb09c358

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL:
<http://dovecot.org/pipermail/dovecot/attachments/20100316/9d76fad8/attachment-0002.bin>

On 16/03/10 17:16, Timo Sirainen wrote:
> On Thu, 2010-02-25 at 13:30 +0200, Tomi Vainio wrote:
>> Hi,
>>
>> 2.0 compiles fine in Solaris but and I've found only one glitch so
far.
>>    Tcpwapper support needs some tweaks.  I need to add
>> CPPFLAGS=/usr/sfw/include  because tcpd.h is in there.  Then also
>> LDFLAGS='-R/usr/sfw/lib -L/usr/sfw/lib' is needed.  It would be
nice to
>> have --with-tcpwrap-dir or something.
>
> I've generally avoided adding any --with-something=paths, since all of
> them can be done with those CPPFLAGS/LDFLAGS changes. And with other
> software that has them, I'm usually just more confused about what I
> should give them as the path. Sometimes they work as I guessed,
> sometimes not..
>
>> These are not defined but application itself should define these
>> globally so I've added these to configure and src/util/tcpwrap.c
>> #include<syslog.h>
>> int allow_severity = LOG_INFO;
>> int deny_severity = LOG_WARNING;
>
> Added: http://hg.dovecot.org/dovecot-2.0/rev/0d17bb09c358
>
Hi,

This addition is also needed in configure because libwrap detection 
fails without it.
checking for request_init in -lwrap is the test which needs to be modified.

   Tomppa