dovecot - Dec 2009 - Different PROXY for IMAP and POP3 using LDAP-auth

--------------------------------------------------
For all non german speaking people:

Oliver asked:
In an old posting I've read something about different proxy hosts for
IMAP and POP3.
http://www.dovecot.org/list/dovecot/2008-July/031885.html

I've got the same problem and want to ask you, if there is a patch for
replacing [variable names in] pass_attrs.
---------------------------------------------------

Hello Oliver,

I've attached the patch I'm using. It works in all 1.1.x versions.

Regards, Ralf


Oliver Eales schrieb am 13.12.2009 01:40:
> Hallo,
> 
> ich hatte ein etwas ?lteres Posting von Ihnen auf der Dovecot
> Mailingliste gefunden bei dem es um unterschiedliche Proxy hosts f?r
> IMAP und POP3 ging.
> http://www.dovecot.org/list/dovecot/2008-July/031885.html
> 
> Ich habe das gleiche Problem und wollte fragen ob sie evtl. einen Patch
> zu Ersetzung der pass_attrs umgesetzt haben.
> 
> Danke und viele Gr??e,
> Oliver Eales
> 
>  
> 
-- 
______________________________________________________________________

 Dipl.-Inform. (FH) Ralf Becker     Rechenzentrum (r/ft) der FH Trier
 (Network|Mail|Web|Firewall)           University of applied sciences
 Administrator                           Schneidershof, D-54293 Trier

   Mail: beckerr at fh-trier.de                    Fon: +49 651 8103 499
    Web: http://www.fh-trier.de/~beckerr        Fax: +49 651 8103 214
 PubKey: http://www.fh-trier.de/~beckerr     Crypto: GnuPG, S/MIME
______________________________________________________________________

 Wenn Gott gewollt haette, dass E-Mail in HTML geschrieben wuerden,
 endeten Gebete traditionell mit </amen>. (Tom Listen)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dovecot-ldap-attribute-templates.patch.gz
Type: application/x-gzip
Size: 878 bytes
Desc: not available
URL:
<http://dovecot.org/pipermail/dovecot/attachments/20091213/46b7a1f9/attachment-0002.gz>

On Sun, 2009-12-13 at 10:59 +0100, Ralf Becker wrote:
> +attr_names_r[i] = p_strdup(auth_request->pool, str_c(str));
auth_request->pool gets freed when this auth request finishes.
> +hash_insert(conn->user_attr_map,attr_names_r[i],
> +	hash_lookup(conn->user_attr_map,attr_names[i]));
Here you add it to conn->*_attr_map and it stays permanently there. So
it looks like it's leaking memory for each request, and also if there
are hash collisions it'll probably crash because there are entries that
point to freed memory.

So you probably should be doing something like first checking if there
already exists such an entry in hash, and if not then do i_strdup() for
the name before adding it to hash.

I was thinking about adding something like this to v2.0 code, but the
hash table updating is pretty ugly.. I think I'll wait adding this until
I'll do a larger rewrite of LDAP configuration.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL:
<http://dovecot.org/pipermail/dovecot/attachments/20091215/8ed2b694/attachment-0002.bin>