While researching a possible bug in our custom-made Maildir++ expiration script, I found the following in src/plugins/quota/quota-maildir.c. | static const char * | maildir_list_next(struct maildir_list_context *ctx, time_t *mtime_r) | { | [...] | *mtime_r = st.st_size; | return str_c(ctx->path); | } As far as I unterstand, this seems incorrect, because the value in mtime_r is used, for example, in maildirs_check_have_changed to check whether any maildirs or folders have changed. If this isn't a bug, please satisfy my own curiosity and tell me what I'm missing. Ulrich
On Tue, 2008-12-09 at 17:49 +0100, Ulrich Zehl wrote:> While researching a possible bug in our custom-made Maildir++ expiration > script, I found the following in src/plugins/quota/quota-maildir.c. > > | static const char * > | maildir_list_next(struct maildir_list_context *ctx, time_t *mtime_r) > | { > | [...] > | *mtime_r = st.st_size; > | return str_c(ctx->path); > | } > > As far as I unterstand, this seems incorrect, because the value in mtime_r > is used, for example, in maildirs_check_have_changed to check whether any > maildirs or folders have changed.Wonder how I've managed to write that. Thanks, fixed: hg.dovecot.org/dovecot-1.1/rev/9cb619cf8644 -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 197 bytes Desc: This is a digitally signed message part URL: <dovecot.org/pipermail/dovecot/attachments/20081213/a860a846/attachment-0002.bin>