dovecot - May 2007 - PATCH: Deliver looses mail and DSN if Return-Path is missing

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

Dovecot v1.0.0

if there is no Return-Path in the message and Deliver cannot deliver the 
message, no DSN is sent _and_ the MTA is returned 0 (aka success) return 
code, which leads to mail loss.

This is not the case, when the message actually finds a Return-Path, but 
fails to invoke the MTA.

- --- src/deliver/mail-send.c (revision 47)
+++ src/deliver/mail-send.c (working copy)
@@ -42,7 +42,7 @@
             i_info("msgid=%s: Return-Path missing, rejection reason:
%s",
                    orig_msgid == NULL ? "" : str_sanitize(orig_msgid,
80),
                    str_sanitize(reason, 512));
- -           return 0;
+           return EX_TEMPFAIL;
      }

      smtp_client = smtp_client_open(return_addr, NULL, &f);

Bye,

- -- 
Steffen Kaiser
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iQEVAwUBRkGA0S9SORjhbDpvAQIh0Qf/RUkmWnK+LhB3/ZwY+AnyTAYGBPB7qTCp
bVchn4F7zL+W2fIYZGz6YG1bKUtHE3qMQAY3gYijspNZBejS0Z8cTI983ZMwJFP+
ygMAicyEDFSWrFWYnzBnpvHYZEK9VjQ4HnDIkojDQx+pQH0LS/Ve0/JbiaNuwMRQ
g0ay3puas8xiyktRHVHslDfbanrfzwpbO7qtNpFrF9aCKo3RLIhFCKSjaXD75BfQ
K7XrmOjFECkB1bLeaFJrVzm/DoayRn1HusKQjtwKCRx4YBgOP0d5OQGQTvqRLx33
agHXdNxFN6vYB/QbIMcoI6xyWw6POHpiRjLJ5maWsdhlMFIrRVNOJg==xshk
-----END PGP SIGNATURE-----

On Wed, 2007-05-09 at 10:05 +0200, Steffen Kaiser wrote:
> - --- src/deliver/mail-send.c (revision 47)
> +++ src/deliver/mail-send.c (working copy)
> @@ -42,7 +42,7 @@
>              i_info("msgid=%s: Return-Path missing, rejection reason:
%s",
>                     orig_msgid == NULL ? "" :
str_sanitize(orig_msgid, 80),
>                     str_sanitize(reason, 512));
> - -           return 0;
> +           return EX_TEMPFAIL;
>       }
I actually did the exact opposite change a few months ago :)

2007-03-26 00:24  Timo Sirainen <tss at iki.fi>

	* src/deliver/mail-send.c: If we couldn't send a bounce because of
	  a missing Return-Path header, just return success instead of
	  failing with EX_TEMPFAIL.

I'm not sure why I changed that. I think this is a problem only if the
SMTP server is misconfigured not to add the Return-Path header? In that
case I'll change the above i_info() to i_error() also..

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL:
<http://dovecot.org/pipermail/dovecot/attachments/20070509/85fcc9d0/attachment.bin>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wed, 9 May 2007, Matthias Andree wrote:
> No, the "any" MTA - excluding qmail and other incompatible
stuff(*) -
> will act upon sysexits.h values, not errno values (which are often
OK, no objection -> sysexit.h.

Bye,

- -- 
Steffen Kaiser
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iQEVAwUBRkG2tC9SORjhbDpvAQK1JggAnwcpu2s59Tda2Rn9wC/WxijERCofrxQ7
nIJi8jQ0Hoo8/lhJrEfMC6Ekgz7DVdgsvhujGKZ8GY5S5pxBrs2MHI9x5FegqhPq
Rvb6K723kSMiuVf+Xn0NX7zoAbsEjgVy7ltd9G8M4qCAmSFKs7/ATKL5ith8vM01
Ifngi8xjZgdiuWfB5YpCCLVDus4J371cQjZeDOSwAG5ZPD2D6uib9JS4MdZQ/RAm
3C4j4igGYjGc1eRFyXjVe+5ZOrsOycHqA/l+FqJQ9SZA3oIZFlDrqjSA/xpCEmA3
F+lW0+i7sgCooe+T5BNiV3s7XawZeNe3HL1WsfGUiOW0AQlNsM9/9g==wiif
-----END PGP SIGNATURE-----