Fabio Tranchitella
2006-Dec-18 17:42 UTC
[Dovecot] [PATCH] Fix for dovecotpw on powerpc and other architectures
Hi, please apply the following patch to dovecotpw. Without this, it will be unusable on powerpc and (maybe) other architectures where the char is unsigned by default. --- dovecot-1.0/src/util/dovecotpw.c (revisione 2066) +++ dovecot-1.0.new/src/util/dovecotpw.c (copia locale) @@ -40,7 +40,7 @@ const char *user = NULL; char *scheme = NULL; char *plaintext = NULL; - char ch; + signed char ch; int lflag = 0, Vflag = 0; lib_init(); Thanks! Fabio Tranchitella <kobold at debian.org> .''`. Proud Debian GNU/Linux developer, admin and user. : :' : `. `'` http://people.debian.org/~kobold/ `- _____________________________________________________________________ 1024D/7F961564, fpr 5465 6E69 E559 6466 BF3D 9F01 2BF8 EE2B 7F96 1564
Koen Vermeer
2006-Dec-21 20:46 UTC
[Dovecot] [PATCH] Fix for dovecotpw on powerpc and other architectures
Op ma, 18-12-2006 te 18:42 +0100, schreef Fabio Tranchitella:> Hi, please apply the following patch to dovecotpw. Without this, it > will be unusable on powerpc and (maybe) other architectures where > the char is unsigned by default.As the original reporter of the bug, I just wanted to say 'thank you' for the fix! It seems to work on my powerpc-box correctly. Thanks! Koen
Timo Sirainen
2006-Dec-21 21:19 UTC
[Dovecot] [PATCH] Fix for dovecotpw on powerpc and other architectures
On Mon, 2006-12-18 at 18:42 +0100, Fabio Tranchitella wrote:> Hi, please apply the following patch to dovecotpw. Without this, it > will be unusable on powerpc and (maybe) other architectures where > the char is unsigned by default. > > --- dovecot-1.0/src/util/dovecotpw.c (revisione 2066) > +++ dovecot-1.0.new/src/util/dovecotpw.c (copia locale) > @@ -40,7 +40,7 @@ > const char *user = NULL; > char *scheme = NULL; > char *plaintext = NULL; > - char ch; > + signed char ch;It should actually be int. Committed fix to cvs. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part URL: <http://dovecot.org/pipermail/dovecot/attachments/20061221/3cf81930/attachment.bin>