Hello, I've taken a different (better) approach to getting tpop3d-compatible UIDLs: the first attached patch (...md5_modifier.diff) adds a variable expansion modifier (%M) to return the md5sum of the expanded variable in hex. With the patch, you can get tpop3d-compatible UIDLs by setting pop3_uidl_format to %Mf. While testing interactions with other modifiers (e.g. %MUf to get the md5sum in uppercase), I noticed that %U is broken -- it lowercases the input just as %L does. The second patch (...ucase_modifier_fix.diff) is a one-liner to fix that. Finally, the third attached patch (...apop_aesthetics.diff) is another trivial patch to add a space between the server greeting and the APOP challenge. I think it looks better when telnetting to the server to diagnose something, and since spaces are stripped from the end of the login_greeting, editing the code is the only way to add the space. Cheers, -- Ben Winslow <rain at bluecherry.net> -------------- next part -------------- A non-text attachment was scrubbed... Name: dovecot-1.0.beta5-md5_modifier.diff Type: text/x-patch Size: 985 bytes Desc: not available URL: <http://dovecot.org/pipermail/dovecot/attachments/20060410/52bada10/attachment.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: dovecot-1.0.beta5-apop_aesthetics.diff Type: text/x-patch Size: 585 bytes Desc: not available URL: <http://dovecot.org/pipermail/dovecot/attachments/20060410/52bada10/attachment-0001.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: dovecot-1.0.beta5-ucase_modifier_fix.diff Type: text/x-patch Size: 456 bytes Desc: not available URL: <http://dovecot.org/pipermail/dovecot/attachments/20060410/52bada10/attachment-0002.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 827 bytes Desc: OpenPGP digital signature URL: <http://dovecot.org/pipermail/dovecot/attachments/20060410/52bada10/attachment-0003.bin>
On Mon, 2006-04-10 at 14:30 -0400, Ben Winslow wrote:> Hello, > > I've taken a different (better) approach to getting tpop3d-compatible > UIDLs: the first attached patch (...md5_modifier.diff) adds a variable > expansion modifier (%M) to return the md5sum of the expanded variable in > hex. With the patch, you can get tpop3d-compatible UIDLs by setting > pop3_uidl_format to %Mf. > > While testing interactions with other modifiers (e.g. %MUf to get the > md5sum in uppercase), I noticed that %U is broken -- it lowercases the > input just as %L does. The second patch (...ucase_modifier_fix.diff) is > a one-liner to fix that.Thanks, committed these.> Finally, the third attached patch (...apop_aesthetics.diff) is another > trivial patch to add a space between the server greeting and the APOP > challenge. I think it looks better when telnetting to the server to > diagnose something, and since spaces are stripped from the end of the > login_greeting, editing the code is the only way to add the space.You could add greeting = "hello ". Anyway I guess the space could be added there automatically. Your patch however added the space also to the end of line if APOP wasn't used. I changed that and committed. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 191 bytes Desc: This is a digitally signed message part URL: <http://dovecot.org/pipermail/dovecot/attachments/20060412/e76ee5d9/attachment.bin>