Timo, I've noticed a couple of extra compilation errors in last night's snapshot compared to the snapshot I downloaded on Tuesday, probably due to the int -> bool change :- (gcc 3.3.2 on Solaris 8) mbox-sync.c: In function `mbox_sync': mbox-sync.c:1568: warning: comparison is always false due to limited range of data type index-search.c: In function `search_index_arg': index-search.c:131: warning: comparison is always false due to limited range of data type quota-storage.c: In function `quota_check': quota-storage.c:114: warning: passing arg 3 of `quota_try_alloc' from incompatible pointer type together with a few "unused parameter/variable" errors which were there before. I also needed to rewrite half my internal patches :) but that shouldn't have made any difference (they certainly don't involve those files). Best Wishes, Chris -- --+---+---+---+---+---+---+---+---+---+---+---+---+---+---+---+---+---+- Christopher Wakelin, c.d.wakelin@reading.ac.uk IT Services Centre, The University of Reading, Tel: +44 (0)118 378 8439 Whiteknights, Reading, RG6 2AF, UK Fax: +44 (0)118 975 3094
Talking of which, one of my patches is for what I think are minor bugs with LIST and namespaces: 1) LIST "<namespace>" "" should return the delimeter and root name (returns delimeter and ""), I think because namespace_find modifies the "ref" argument 2) LIST "" "<namespace>" probably should return LIST (\Noselect) "<delim>" "<namespace>" (this keeps Pine and possibly other clients happy, otherwise they try to "create" the directory) i.e. for "/" delimeter and "~/mail/" prefix I'd want . LIST "" "~/mail/" * LIST (\Noselect) "/" "~/mail/" . LIST "~/mail/" "" * LIST (\Noselect) "/" "~/" I can supply the patches but the first is trivial and the second one is very ugly! Best Wishes, Chris Chris Wakelin wrote:> I also needed to rewrite half my internal patches :) but that shouldn't > have made any difference (they certainly don't involve those files). > > Best Wishes, > Chris >-- --+---+---+---+---+---+---+---+---+---+---+---+---+---+---+---+---+---+- Christopher Wakelin, c.d.wakelin@reading.ac.uk IT Services Centre, The University of Reading, Tel: +44 (0)118 378 8439 Whiteknights, Reading, RG6 2AF, UK Fax: +44 (0)118 975 3094
On Sat, 2006-01-14 at 14:21 +0000, Chris Wakelin wrote:> Timo, > > I've noticed a couple of extra compilation errors in last night's > snapshot compared to the snapshot I downloaded on Tuesday, probably due > to the int -> bool change :- (gcc 3.3.2 on Solaris 8)Looks like gcc 4.0 has gotten worse with detecting these. Fixed all of them. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part Url : http://dovecot.org/pipermail/dovecot/attachments/20060114/11dbcf80/attachment.pgp