compiz - May 2009 - compiz swapbuffers patch

Here's a compiz patch to assume the presence of a sane glXSwapBuffer
implementation (i.e. one that uses page flips synchronized to vblank).

It adds --no-wait and --always-swap options, which, if used with the
swapbuffers patchset, will make compiz use the page flipping path for
tear-free drawing.

Jesse
-------------- next part --------------
A non-text attachment was scrubbed...
Name: compiz-pageflip-support-2.patch
Type: text/x-patch
Size: 2069 bytes
Desc: not available
Url :
http://lists.freedesktop.org/archives/compiz/attachments/20090507/e16965d3/attachment.bin

Jesse Barnes wrote:

Why are you comparing booleans to TRUE and worse then negating the result?

if( !noWait )

Is clearer.

-			waitForVideoSync (s);
+			if (!(noWait == TRUE))
+			    waitForVideoSync (s);


Barry

Hi Jesse,

I've looked at your patch, and it won't work normally unless the whole
screen is damaged. I assume you're running a plugin that does this by
default, and that's why you missed it. In any case, you need a couple
extra lines. Something like:

if (alwaysSwap == TRUE)
    damageScreen (s);

at src/screen.c:1455 in the original file, or just after the whole "if
(s->slowAnimations)" block.

Good luck getting this patch in. Compiz has needed something like this
for a while.

On Thu, May 7, 2009 at 3:02 PM, Jesse Barnes <jbarnes at virtuousgeek.org>
wrote:
> Here's a compiz patch to assume the presence of a sane glXSwapBuffer
> implementation (i.e. one that uses page flips synchronized to vblank).
>
> It adds --no-wait and --always-swap options, which, if used with the
> swapbuffers patchset, will make compiz use the page flipping path for
> tear-free drawing.
>
> Jesse
> _______________________________________________
> compiz mailing list
> compiz at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/compiz
>
>