compiz - Jul 2007 - [PATCH] plugin conflict resolution between Fade & Animation

Hi,

Having the minimize_open_close option in Fade wasn't enough for
conflict resolution with Animation, since it was on by default. This
makes sense since the Minimize plugin is used by default, which is a
lightweight animation provider that some people/distributions might
prefer over Animation. And nobody really needs to know that this
option resolves the conflict. So here is a better method to resolve
the conflict with animation.

The first patch adds a compiz-event handler to Fade that handles
animation's activate event to suppress fade on minimize/open/close.
The activate event doesn't identify the window being animated. It just
tells that there is an animation going on, which is enough for Fade to
resolve the conflict. Since Fade doesn't need to use
findWindowAtScreen, the performance impact is independent of the
number of windows and should be negligible.

The second patch removes the minimize_open_close option since it's not
necessary anymore (it was introduced to resolve the conflict). I guess
the option is not used for any other purpose by anybody. So it should
be safe to remove.

Especially the first patch is necessary to fix the conflict for good.

Regards,
Erkin
-------------- next part --------------

The patches I sent earlier apparently only worked for window closing.
Animation's activate event was too late for suppressing minimize/open
fading. Here are working patches that are also simpler, they don't
involve any compiz-event handling. Now Fade just checks at the
beginning whether animation is active or not.

Regards,
Erkin

On 7/1/07, Erkin Bahceci <erkinbah at gmail.com>
wrote:
> Hi,
>
> Having the minimize_open_close option in Fade wasn't enough for
> conflict resolution with Animation, since it was on by default. This
> makes sense since the Minimize plugin is used by default, which is a
> lightweight animation provider that some people/distributions might
> prefer over Animation. And nobody really needs to know that this
> option resolves the conflict. So here is a better method to resolve
> the conflict with animation.
>
> The first patch adds a compiz-event handler to Fade that handles
> animation's activate event to suppress fade on minimize/open/close.
> The activate event doesn't identify the window being animated. It just
> tells that there is an animation going on, which is enough for Fade to
> resolve the conflict. Since Fade doesn't need to use
> findWindowAtScreen, the performance impact is independent of the
> number of windows and should be negligible.
>
> The second patch removes the minimize_open_close option since it's not
> necessary anymore (it was introduced to resolve the conflict). I guess
> the option is not used for any other purpose by anybody. So it should
> be safe to remove.
>
> Especially the first patch is necessary to fix the conflict for good.
>
> Regards,
> Erkin
>
>
-------------- next part --------------