Btrfs devel - Apr 2013 - [PATCH] xfstests: remove recursive include in filter.btrfs

Not sure how this happened, but filter.btrfs including
itself leads to immense sadness for any file that includes it.
(I got a segfault when I tried to run 307)

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

diff --git a/common/filter.btrfs b/common/filter.btrfs
index b1aa733..99d04a6 100644
--- a/common/filter.btrfs
+++ b/common/filter.btrfs
@@ -1,7 +1,5 @@
 # Filters for btrfs command output
 
-. ./common/filter.btrfs
-
 # Some, but not all, commands emit "Btrfs <version>"
 _filter_btrfs_version()
 {

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Not sure how this happened, but filter.btrfs including
itself leads to immense sadness for any file that includes it.
(I got a segfault when I tried to run 307)

It should be including the common/filter not common/filter.btrfs

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

diff --git a/common/filter.btrfs b/common/filter.btrfs
index b1aa733..3435d8d 100644
--- a/common/filter.btrfs
+++ b/common/filter.btrfs
@@ -1,6 +1,6 @@
 # Filters for btrfs command output
 
-. ./common/filter.btrfs
+. ./filter
 
 # Some, but not all, commands emit "Btrfs <version>"
 _filter_btrfs_version()

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Not sure how this happened, but filter.btrfs including
itself leads to immense sadness for any file that includes it.
(I got a segfault when I tried to run 307)

It should be including ./common/filter not ./common/filter.btrfs

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

cripes, I''m sorry that took 3 times to get right :/

diff --git a/common/filter.btrfs b/common/filter.btrfs
index b1aa733..e9a2bc2 100644
--- a/common/filter.btrfs
+++ b/common/filter.btrfs
@@ -1,6 +1,6 @@
 # Filters for btrfs command output
 
-. ./common/filter.btrfs
+. ./common/filter
 
 # Some, but not all, commands emit "Btrfs <version>"
 _filter_btrfs_version()


--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

On 04/21/2013 05:51 PM, Eric Sandeen wrote:
> Not sure how this happened, but filter.btrfs including
> itself leads to immense sadness for any file that includes it.
> (I got a segfault when I tried to run 307)
>
> It should be including ./common/filter not ./common/filter.btrfs
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> cripes, I''m sorry that took 3 times to get right :/
>
Third time is the charm ;) Looks good.

Reviewed-by: Rich Johnston <rjohnston@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Thanks for the patch Eric, V3 has been committed.

--Rich

commit e771c54c45a5c475bedbc5a2d6becc05be940dba
Author: Eric Sandeen <sandeen@sandeen.net>
Date:   Sun Apr 21 22:51:54 2013 +0000

     xfstests: fix common filter include in filter.btrfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs