Henry Bakker
2012-May-22 21:42 UTC
Could btrfs-restore be extended to also restore file dates?
Any possibility of getting btrfs-restore to also restore the files timestamp? I''m doing a restore right now as I had one btrfs partition blow up and I''m noting that the timestamps are marking all the restored files as new. It would be nice to be able to do a quick compare of file dates to determine any changed files that may be newer on the restore vs the backup. (I can save full file compares for when the server is not being actively used.) I do realize it is possible that there could be other issues, but for quickly determining potential issues this could be useful. I do realize that there may be technical reasons for the current behavior, so at the very least this is suggestion for future functionality even if it doesn''t help me. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
David Sterba
2012-May-23 09:07 UTC
Re: Could btrfs-restore be extended to also restore file dates?
On Tue, May 22, 2012 at 03:42:05PM -0600, Henry Bakker wrote:> Any possibility of getting btrfs-restore to also restore the files > timestamp?Quick look, yes it is possible and quite straightforward. The function restore.c:copy_file has direct access to the found on-disk inode item and can access the time fileds, then simply setting them for the file. Maybe it could restore more, like uid, gid or mode. david -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Henry Bakker
2012-May-23 14:13 UTC
Re: Could btrfs-restore be extended to also restore file dates?
I''m sure restoring all those fields would be functionality that most server admins would want. If anyone on this list can add it, then you have my thanks. On 5/23/2012 3:07 AM, David Sterba wrote:> On Tue, May 22, 2012 at 03:42:05PM -0600, Henry Bakker wrote: >> Any possibility of getting btrfs-restore to also restore the files >> timestamp? > > Quick look, yes it is possible and quite straightforward. The function > restore.c:copy_file has direct access to the found on-disk inode item > and can access the time fileds, then simply setting them for the file. > Maybe it could restore more, like uid, gid or mode. > > > david > >-- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html