Arnd Hannemann
2011-Nov-14 15:24 UTC
[PATCH] Btrfs-progs: satisfy compiler and change printf modifier
One-liner which fixes the gcc warning:
warning: format ''%u'' expects argument of type
''unsigned int'',
but argument 3 has type ''long unsigned int'' [-Wformat]
Signed-off-by: Arnd Hannemann <arnd@arndnet.de>
---
extent-tree.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/extent-tree.c b/extent-tree.c
index 5bed3c2..5211bee 100644
--- a/extent-tree.c
+++ b/extent-tree.c
@@ -1067,7 +1067,7 @@ static int lookup_inline_extent_backref(struct
btrfs_trans_handle *trans,
}
#endif
if (item_size < sizeof(*ei)) {
- printf("Size is %u, needs to be %u, slot %d\n", item_size,
+ printf("Size is %u, needs to be %zu, slot %d\n", item_size,
sizeof(*ei), path->slots[0]);
btrfs_print_leaf(root, leaf);
return -EINVAL;
--
1.7.5.4
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Arnd Hannemann
2011-Nov-14 15:51 UTC
Re: [PATCH] Btrfs-progs: satisfy compiler and change printf modifier
Am 14.11.2011 16:30, schrieb Christian Parpart:> On Mon, Nov 14, 2011 at 4:24 PM, Arnd Hannemann <arnd@arndnet.de <mailto:arnd@arndnet.de>> wrote: > > One-liner which fixes the gcc warning: > warning: format ''%u'' expects argument of type ''unsigned int'', > but argument 3 has type ''long unsigned int'' [-Wformat] > > > [snip] > > - printf("Size is %u, needs to be %u, slot %d\n", item_size, > + printf("Size is %u, needs to be %zu, slot %d\n", item_size, > sizeof(*ei), path->slots[0]); > > > shouldn''t it be %lu then (instead of %zu) ?No, the return type of sizeof() is size_t which is of different size on different architectures (eg. amd64 versus i386) If %lu would be used, there would be a warning when compiled on an architecture where long is 32 bit. Best regards, Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html