Tony Hillerson
2008-Jul-08 21:50 UTC
[Betternestedset-talk] Better Nested Set Patch for Rails 2.1
I tried to send this proposed patch at the beginning of June, but failed and sent the man page. I then tried to reply and send the patch, but that obviously didn''t make it. I apologize for being dumb. Here''s the patch one more time. Apply the patch to betternestedset/lib/better_nested_set.rb. Just to let you all know, I''ve switched from Better Nested Set to Awesome Nested Set, and it''s been a pretty much drop in replacement. The only thing to note that I know of is that add_child is fully removed instead of deprecated in favor of move_to_child_of. Here''s the repo for awesome nested set: http://github.com/collectiveidea/awesome_nested_set/tree/master I don''t mean to start any conflict about which project you should be using, but it just seems that better nested set is no longer maintained. Thanks, Tony Hillerson -------------- next part -------------- A non-text attachment was scrubbed... Name: better_nested_set.rb.patch Type: application/octet-stream Size: 1681 bytes Desc: not available URL: <http://rubyforge.org/pipermail/betternestedset-talk/attachments/20080708/2ca4555f/attachment-0001.obj>
Kevin Triplett
2008-Jul-08 23:05 UTC
[Betternestedset-talk] Better Nested Set Patch for Rails 2.1
Excellent! I was waiting for a nested set plugin to be hosted at github. Thanks! I''ll try to submit a patch for my move_to_tree_of method there in the next two weeks, if everything looks good with ANS. Tony Hillerson wrote:> I tried to send this proposed patch at the beginning of June, but > failed and sent the man page. I then tried to reply and send the > patch, but that obviously didn''t make it. I apologize for being dumb. > Here''s the patch one more time. Apply the patch to > betternestedset/lib/better_nested_set.rb. > > Just to let you all know, I''ve switched from Better Nested Set to > Awesome Nested Set, and it''s been a pretty much drop in replacement. > The only thing to note that I know of is that add_child is fully > removed instead of deprecated in favor of move_to_child_of. > > Here''s the repo for awesome nested set: > http://github.com/collectiveidea/awesome_nested_set/tree/master > > I don''t mean to start any conflict about which project you should be > using, but it just seems that better nested set is no longer > maintained. > > Thanks, > Tony Hillerson > > > ------------------------------------------------------------------------ > > _______________________________________________ > Betternestedset-talk mailing list > Betternestedset-talk at rubyforge.org > http://rubyforge.org/mailman/listinfo/betternestedset-talk
Christopher Bailey
2008-Jul-15 08:36 UTC
[Betternestedset-talk] Better Nested Set Patch for Rails 2.1
Tony, does deletion/destroy work properly for you with ANS? I''ve been looking at possibly switching as well, as ANS solves one problem I have, but destroy''s don''t seem to proplery destroy all descendants. For example, if I have "locations", and say I have Califnornia, and it has two direct children, "Los Angeles" and "San Francisco". When I delete California, it only deletes one of the child cities. On Tue, Jul 8, 2008 at 2:50 PM, Tony Hillerson <tony.hillerson at gmail.com> wrote:> I tried to send this proposed patch at the beginning of June, but > failed and sent the man page. I then tried to reply and send the > patch, but that obviously didn''t make it. I apologize for being dumb. > Here''s the patch one more time. Apply the patch to > betternestedset/lib/better_nested_set.rb. > > Just to let you all know, I''ve switched from Better Nested Set to > Awesome Nested Set, and it''s been a pretty much drop in replacement. > The only thing to note that I know of is that add_child is fully > removed instead of deprecated in favor of move_to_child_of. > > Here''s the repo for awesome nested set: > http://github.com/collectiveidea/awesome_nested_set/tree/master > > I don''t mean to start any conflict about which project you should be > using, but it just seems that better nested set is no longer > maintained. > > Thanks, > Tony Hillerson > > _______________________________________________ > Betternestedset-talk mailing list > Betternestedset-talk at rubyforge.org > http://rubyforge.org/mailman/listinfo/betternestedset-talk > >-- Christopher Bailey Cobalt Edge LLC http://cobaltedge.com
Tony Hillerson
2008-Jul-15 14:22 UTC
[Betternestedset-talk] Better Nested Set Patch for Rails 2.1
We did some tests on that and it seems that destroying the root destroys all the children. On 7/15/08 2:36 AM, "Christopher Bailey" <chris at cobaltedge.com> wrote: Tony, does deletion/destroy work properly for you with ANS? I''ve been looking at possibly switching as well, as ANS solves one problem I have, but destroy''s don''t seem to proplery destroy all descendants. For example, if I have "locations", and say I have Califnornia, and it has two direct children, "Los Angeles" and "San Francisco". When I delete California, it only deletes one of the child cities. On Tue, Jul 8, 2008 at 2:50 PM, Tony Hillerson <tony.hillerson at gmail.com> wrote:> I tried to send this proposed patch at the beginning of June, but > failed and sent the man page. I then tried to reply and send the > patch, but that obviously didn''t make it. I apologize for being dumb. > Here''s the patch one more time. Apply the patch to > betternestedset/lib/better_nested_set.rb. > > Just to let you all know, I''ve switched from Better Nested Set to > Awesome Nested Set, and it''s been a pretty much drop in replacement. > The only thing to note that I know of is that add_child is fully > removed instead of deprecated in favor of move_to_child_of. > > Here''s the repo for awesome nested set: > http://github.com/collectiveidea/awesome_nested_set/tree/master > > I don''t mean to start any conflict about which project you should be > using, but it just seems that better nested set is no longer > maintained. > > Thanks, > Tony Hillerson > > _______________________________________________ > Betternestedset-talk mailing list > Betternestedset-talk at rubyforge.org > http://rubyforge.org/mailman/listinfo/betternestedset-talk > >-- Christopher Bailey Cobalt Edge LLC http://cobaltedge.com _______________________________________________ Betternestedset-talk mailing list Betternestedset-talk at rubyforge.org http://rubyforge.org/mailman/listinfo/betternestedset-talk -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/betternestedset-talk/attachments/20080715/d6bf1e7f/attachment.html>
Christopher Bailey
2008-Jul-15 16:04 UTC
[Betternestedset-talk] Better Nested Set Patch for Rails 2.1
I''m still having issues. But, after applying your Rails 2.1 patch to BNS, I''m good to go there. For anyone interested, I have Better Nested Set on GitHub, with this patch applied: http://github.com/chris/better_nested_set/tree/master On Tue, Jul 15, 2008 at 7:22 AM, Tony Hillerson <Tony.Hillerson at effectiveui.com> wrote:> We did some tests on that and it seems that destroying the root destroys all > the children. > > > On 7/15/08 2:36 AM, "Christopher Bailey" <chris at cobaltedge.com> wrote: > > Tony, does deletion/destroy work properly for you with ANS? I''ve been > looking at possibly switching as well, as ANS solves one problem I > have, but destroy''s don''t seem to proplery destroy all descendants. > For example, if I have "locations", and say I have Califnornia, and it > has two direct children, "Los Angeles" and "San Francisco". When I > delete California, it only deletes one of the child cities. > > On Tue, Jul 8, 2008 at 2:50 PM, Tony Hillerson <tony.hillerson at gmail.com> > wrote: >> I tried to send this proposed patch at the beginning of June, but >> failed and sent the man page. I then tried to reply and send the >> patch, but that obviously didn''t make it. I apologize for being dumb. >> Here''s the patch one more time. Apply the patch to >> betternestedset/lib/better_nested_set.rb. >> >> Just to let you all know, I''ve switched from Better Nested Set to >> Awesome Nested Set, and it''s been a pretty much drop in replacement. >> The only thing to note that I know of is that add_child is fully >> removed instead of deprecated in favor of move_to_child_of. >> >> Here''s the repo for awesome nested set: >> http://github.com/collectiveidea/awesome_nested_set/tree/master >> >> I don''t mean to start any conflict about which project you should be >> using, but it just seems that better nested set is no longer >> maintained. >> >> Thanks, >> Tony Hillerson >> >> _______________________________________________ >> Betternestedset-talk mailing list >> Betternestedset-talk at rubyforge.org >> http://rubyforge.org/mailman/listinfo/betternestedset-talk >> >> > > > > -- > Christopher Bailey > Cobalt Edge LLC > http://cobaltedge.com > _______________________________________________ > Betternestedset-talk mailing list > Betternestedset-talk at rubyforge.org > http://rubyforge.org/mailman/listinfo/betternestedset-talk > > > > _______________________________________________ > Betternestedset-talk mailing list > Betternestedset-talk at rubyforge.org > http://rubyforge.org/mailman/listinfo/betternestedset-talk > >-- Christopher Bailey Cobalt Edge LLC http://cobaltedge.com
Jean-Christophe Michel
2008-Jul-15 17:13 UTC
[Betternestedset-talk] Better Nested Set Patch for Rails 2.1
Hi, Le 15 juil. 08 ? 18:04, Christopher Bailey a ?crit :> I''m still having issues. But, after applying your Rails 2.1 patch to > BNS, I''m good to go there. For anyone interested, I have Better > Nested Set on GitHub, with this patch applied: > > http://github.com/chris/better_nested_set/tree/masterThanks. I''ll ask everybody to decide wether to migrate rubyforge to git. Jean-Christophe Michel -- symetrie.com Better Nested Set for rails: http://opensource.symetrie.com/trac/better_nested_set