asterisk users - Feb 2020 - install_prereq install-unpackaged fails on Debian Buster

Hello,

For the very first time, I tried the command bellow on a newly build Debian
Buster box on which I successfully built Asterisk 17.2.0 before. I got :

# contrib/scripts/install_prereq install-unpackaged
*** Installing NBS (Network Broadcast Sound) ***
A    nbs-trunk/LICENSE
A    nbs-trunk/nbsclient.c
A    nbs-trunk/nbsd.c
A    nbs-trunk/nbs.h
A    nbs-trunk/nbscat.c
A    nbs-trunk/Makefile
A    nbs-trunk/nbscat8k
A    nbs-trunk/xmms-nbs-1.2.10.patch
A    nbs-trunk/xmms-nbs-orig.patch
Révision 15 extraite.
cc -g -Wall -O2 -D_NBS_PRIVATE -Wmissing-prototypes -Werror
-Wno-pointer-sign -D_REENTRANT   -c -o nbsd.o nbsd.c
nbsd.c: In function ‘handle_network’:
nbsd.c:453:5: error: ‘strncpy’ output may be truncated copying 79 bytes
from a string of length 79 [-Werror=stringop-truncation]
     strncpy(ns->name, si->streamname, sizeof(ns->name) - 1);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
nbsd.c:454:5: error: ‘strncpy’ output may be truncated copying 15 bytes
from a string of length 15 [-Werror=stringop-truncation]
     strncpy(ns->app, si->appname, sizeof(ns->app) - 1);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In function ‘audio_acquire’,
    inlined from ‘merge_stream’ at nbsd.c:276:9,
    inlined from ‘timing_ready’ at nbsd.c:566:10:
nbsd.c:221:4: error: ‘strncpy’ output may be truncated copying 79 bytes
from a string of length 79 [-Werror=stringop-truncation]
    strncpy(ih.i.streamname, ns->name, sizeof(ih.i.streamname) - 1);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
nbsd.c:222:4: error: ‘strncpy’ output may be truncated copying 15 bytes
from a string of length 15 [-Werror=stringop-truncation]
    strncpy(ih.i.appname, ns->app, sizeof(ih.i.appname) - 1);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make: *** [<commande interne>: nbsd.o] Error 1

Thoughts ?
Suggestions ?

Best regards
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.digium.com/pipermail/asterisk-users/attachments/20200218/91a4a94f/attachment.html>

On Tue, Feb 18, 2020 at 8:16 AM Olivier <oza.4h07 at gmail.com> wrote:
> Hello,
>
> For the very first time, I tried the command bellow on a newly build
> Debian Buster box on which I successfully built Asterisk 17.2.0 before. I
> got :
>
> # contrib/scripts/install_prereq install-unpackaged
> *** Installing NBS (Network Broadcast Sound) ***
> A    nbs-trunk/LICENSE
> A    nbs-trunk/nbsclient.c
> A    nbs-trunk/nbsd.c
> A    nbs-trunk/nbs.h
> A    nbs-trunk/nbscat.c
> A    nbs-trunk/Makefile
> A    nbs-trunk/nbscat8k
> A    nbs-trunk/xmms-nbs-1.2.10.patch
> A    nbs-trunk/xmms-nbs-orig.patch
> Révision 15 extraite.
> cc -g -Wall -O2 -D_NBS_PRIVATE -Wmissing-prototypes -Werror
> -Wno-pointer-sign -D_REENTRANT   -c -o nbsd.o nbsd.c
> nbsd.c: In function ‘handle_network’:
> nbsd.c:453:5: error: ‘strncpy’ output may be truncated copying 79 bytes
> from a string of length 79 [-Werror=stringop-truncation]
>      strncpy(ns->name, si->streamname, sizeof(ns->name) - 1);
>      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> nbsd.c:454:5: error: ‘strncpy’ output may be truncated copying 15 bytes
> from a string of length 15 [-Werror=stringop-truncation]
>      strncpy(ns->app, si->appname, sizeof(ns->app) - 1);
>      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In function ‘audio_acquire’,
>     inlined from ‘merge_stream’ at nbsd.c:276:9,
>     inlined from ‘timing_ready’ at nbsd.c:566:10:
> nbsd.c:221:4: error: ‘strncpy’ output may be truncated copying 79 bytes
> from a string of length 79 [-Werror=stringop-truncation]
>     strncpy(ih.i.streamname, ns->name, sizeof(ih.i.streamname) - 1);
>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> nbsd.c:222:4: error: ‘strncpy’ output may be truncated copying 15 bytes
> from a string of length 15 [-Werror=stringop-truncation]
>     strncpy(ih.i.appname, ns->app, sizeof(ih.i.appname) - 1);
>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make: *** [<commande interne>: nbsd.o] Error 1
>
> Thoughts ?
> Suggestions ?
>
It is highly unlikely that you need chan_nbs so the easiest option is to
edit the install_prereq script and remove that portion. I'd suggest filing
an issue[1] so this doesn't get lost. As well generally install-unpackaged
isn't usually needed.

[1] https://issues.asterisk.org/jira

-- 
Joshua C. Colp
Asterisk Technical Lead
Sangoma Technologies
Check us out at www.sangoma.com and www.asterisk.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.digium.com/pipermail/asterisk-users/attachments/20200218/6157825d/attachment.html>