asterisk users - Jan 2006 - RX/TXgain on bristuff/zaptel ?

Do bristuffed zaptel (zaphfc) supporting rxgain/txgain in zapata.conf?

I'm changing rxgain in zapata.conf, and reloading zaptel, but sound
level on ISDN(HFC) is always the same (loud).

On Sunday, January 15, 2006 3:41 PM Pisac wrote: 
> Do bristuffed zaptel (zaphfc) supporting rxgain/txgain in zapata.conf?
Please recheck: This happens on outgoing calls only, correct? On inbound
calls rxgain/txgain work? There is a bug in current bristuff: Somwhere
around line 1928 you should find a few lines regarding gain. Change them
to look like this:

        if (IS_DIGITAL(ast->transfercapability)) {
            set_actual_gain(p->subs[SUB_REAL].zfd, 0, 0, 0, p->law);
        } else { 
            set_actual_gain(p->subs[SUB_REAL].zfd, 0, p->rxgain,
p->txgain, p->law);
        }

Recompile and things will start working on outgoing calls as well.

Kind regards,
  JP

On Tuesday, January 17, 2006 4:13 PM Pisac wrote:
> You are right, only outgoing calls!
> I found lines that you mentioned, but I do not understand where is
> difference? In current chan_zap.c I read: 
> 
> if (!IS_DIGITAL(ast->transfercapability)) {
> set_actual_gain(p->subs[SUB_REAL].zfd, 0, p->rxgain, p->txgain,
> p->law); } else { set_actual_gain(p->subs[SUB_REAL].zfd, 0, 0, 0,
> p->law); }   
> 
> And your suggestion is:
> 
> if (IS_DIGITAL(ast->transfercapability)) {
> set_actual_gain(p->subs[SUB_REAL].zfd, 0, 0, 0, p->law); } else {
> set_actual_gain(p->subs[SUB_REAL].zfd, 0, p->rxgain, p->txgain,
> p->law); }   
> 
> Which is the same thing but invertedly written. I'm not a programmer,
> so I may be wrong (maybe IS_DIGITAL could be NULL), but I would like
> to understand difference in those two segments.  
I know. It sounds crazy. Trust me though. Somehow the original does not work.
This fix is from the bristuff developer himself and it does work.

Regards,
  JP