Peter Eisentraut
2005-Sep-02 10:10 UTC
Bug#326192: adduser: adding system user with existing group fails
Package: adduser
Version: 3.67
Severity: normal
The postgresql-common package does the following to add its system user
"postgres":
if ! getent passwd postgres > /dev/null; then
adduser --system --quiet --no-create-home --home /var/lib/postgresql
--group --gecos "PostgreSQL administrator" pos
fi
I suppose this is common usage.
If, for whatever reason, the "postgres" group already exists, that
call
fails:
adduser: The group `postgres'' already exists.
($? = 1)
As a consequence, the whole package installation fails in this case.
That makes adduser --system --group a rather fragile combination. I suggest
that the existing group is not really an error and the new user should
simply be added to the existing group.
Marc Haber
2005-Sep-03 08:19 UTC
[Adduser-devel] Bug#326192: adduser: adding system user with existing group fails
tags #326192 wontfix thanks On Fri, Sep 02, 2005 at 11:50:18AM +0200, Peter Eisentraut wrote:> The postgresql-common package does the following to add its system user > "postgres": > > if ! getent passwd postgres > /dev/null; then > adduser --system --quiet --no-create-home --home /var/lib/postgresql --group --gecos "PostgreSQL administrator" pos > fi > > I suppose this is common usage. > > If, for whatever reason, the "postgres" group already exists, that call > fails: > > adduser: The group `postgres'' already exists. > > ($? = 1) > > As a consequence, the whole package installation fails in this case.Which is a feature. adduser only silently adds a new system user to an existing group if the existing group is a system group. If the existing group is not a system group, adduser assumes that the group name is locally being used for some thing else and refrains from giving a new system user potential privileges on user data.> That makes adduser --system --group a rather fragile combination. I suggest > that the existing group is not really an error and the new user should > simply be added to the existing group.adduser behaves that way if the existing group is a system group. Greetings Marc -- ----------------------------------------------------------------------------- Marc Haber | "I don''t trust Computers. They | Mailadresse im Header Mannheim, Germany | lose things." Winona Ryder | Fon: *49 621 72739834 Nordisch by Nature | How to make an American Quilt | Fax: *49 621 72739835
Debian Bug Tracking System
2005-Sep-03 08:19 UTC
[Adduser-devel] Processed: Re: Bug#326192: adduser: adding system user with existing group fails
Processing commands for control@bugs.debian.org:> tags #326192 wontfixBug#326192: adduser: adding system user with existing group fails There were no tags set. Tags added: wontfix> thanksStopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database)
Peter Eisentraut
2005-Sep-05 12:19 UTC
[Adduser-devel] Bug#326192: adduser: adding system user with existing group fails
Am Samstag, 3. September 2005 10:11 schrieb Marc Haber:> Which is a feature. adduser only silently adds a new system user to an > existing group if the existing group is a system group. If the > existing group is not a system group, adduser assumes that the group > name is locally being used for some thing else and refrains from > giving a new system user potential privileges on user data.OK, that makes sense. So forget this bug, but maybe I can request that these circumstances are explained in the error message. So maybe it could look like this: adduser: The group `postgres'' already exists and is not a system group.
Marc Haber
2005-Oct-01 18:33 UTC
[Adduser-devel] Bug#326192: adduser: adding system user with existing group fails
tags #326192 - wontfix tags #326192 confirmed pending thanks On Mon, Sep 05, 2005 at 12:50:10PM +0200, Peter Eisentraut wrote:> Am Samstag, 3. September 2005 10:11 schrieb Marc Haber: > > Which is a feature. adduser only silently adds a new system user to an > > existing group if the existing group is a system group. If the > > existing group is not a system group, adduser assumes that the group > > name is locally being used for some thing else and refrains from > > giving a new system user potential privileges on user data. > > OK, that makes sense. So forget this bug, but maybe I can request that these > circumstances are explained in the error message. So maybe it could look > like this: > > adduser: The group `postgres'' already exists and is not a system group.Thanks for that idea. Committed to svn. Greetings Marc -- ----------------------------------------------------------------------------- Marc Haber | "I don''t trust Computers. They | Mailadresse im Header Mannheim, Germany | lose things." Winona Ryder | Fon: *49 621 72739834 Nordisch by Nature | How to make an American Quilt | Fax: *49 621 72739835
Debian Bug Tracking System
2005-Oct-01 18:33 UTC
[Adduser-devel] Processed: Re: Bug#326192: adduser: adding system user with existing group fails
Processing commands for control@bugs.debian.org:> tags #326192 - wontfixBug#326192: adduser: adding system user with existing group fails Tags were: wontfix Tags removed: wontfix> tags #326192 confirmed pendingBug#326192: adduser: adding system user with existing group fails There were no tags set. Tags added: confirmed, pending> thanksStopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database)
Debian Bug Tracking System
2005-Oct-03 21:03 UTC
[Adduser-devel] Bug#326192: marked as done (adduser: adding system user with existing group fails)
Your message dated Mon, 3 Oct 2005 22:54:23 +0200 with message-id <20051003205423.GA8905@torres.l21.ma.zugschlus.de> and subject line Fixed in upload of adduser 3.70 to experimental has caused the attached Bug report to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what I am talking about this indicates a serious mail system misconfiguration somewhere. Please contact me immediately.) Debian bug tracking system administrator (administrator, Debian Bugs database) -------------------------------------- Received: (at submit) by bugs.debian.org; 2 Sep 2005 09:50:43 +0000>From peter_e@gmx.net Fri Sep 02 02:50:43 2005Return-path: <peter_e@gmx.net> Received: from master.debian.org [146.82.138.7] by spohr.debian.org with esmtp (Exim 3.36 1 (Debian)) id 1EB8C3-0004qD-00; Fri, 02 Sep 2005 02:50:43 -0700 Received: from p50895534.dip.t-dialin.net (bell.credativ.de) [80.137.85.52] by master.debian.org with esmtp (Exim 3.35 1 (Debian)) id 1EB8C1-0007aw-00; Fri, 02 Sep 2005 04:50:42 -0500 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Peter Eisentraut <peter_e@gmx.net> To: Debian Bug Tracking System <submit@bugs.debian.org> Subject: adduser: adding system user with existing group fails X-Mailer: reportbug 3.15 Date: Fri, 02 Sep 2005 11:50:18 +0200 Message-Id: <E1EB8C1-0007aw-00@master.debian.org> Delivered-To: submit@bugs.debian.org X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 (1.212-2003-09-23-exp) on spohr.debian.org X-Spam-Level: X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_PACKAGE, OUR_MTA_MSGID autolearn=no version=2.60-bugs.debian.org_2005_01_02 Package: adduser Version: 3.67 Severity: normal The postgresql-common package does the following to add its system user "postgres": if ! getent passwd postgres > /dev/null; then adduser --system --quiet --no-create-home --home /var/lib/postgresql --group --gecos "PostgreSQL administrator" pos fi I suppose this is common usage. If, for whatever reason, the "postgres" group already exists, that call fails: adduser: The group `postgres'' already exists. ($? = 1) As a consequence, the whole package installation fails in this case. That makes adduser --system --group a rather fragile combination. I suggest that the existing group is not really an error and the new user should simply be added to the existing group. --------------------------------------- Received: (at 326192-done) by bugs.debian.org; 3 Oct 2005 20:54:25 +0000>From mh+debian-packages@zugschlus.de Mon Oct 03 13:54:25 2005Return-path: <mh+debian-packages@zugschlus.de> Received: from 5301d.unt0.torres.l21.ma.zugschlus.de (torres.zugschlus.de) [217.151.83.1] (Debian-exim) by spohr.debian.org with esmtp (Exim 3.36 1 (Debian)) id 1EMXKL-0005rK-00; Mon, 03 Oct 2005 13:54:25 -0700 Received: from mh by torres.zugschlus.de with local (Exim 4.53) id 1EMXKJ-0002Rm-Ad; Mon, 03 Oct 2005 22:54:23 +0200 Date: Mon, 3 Oct 2005 22:54:23 +0200 From: Marc Haber <mh+debian-packages@zugschlus.de> To: Marc Haber <mh+debian-packages@zugschlus.de> Cc: 326192-done@bugs.debian.org, 327804-done@bugs.debian.org, 330258-done@bugs.debian.org, 331392-done@bugs.debian.org Subject: Re: Fixed in upload of adduser 3.70 to experimental Message-ID: <20051003205423.GA8905@torres.l21.ma.zugschlus.de> References: <E1EMWkG-0008Mh-00@spohr.debian.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <E1EMWkG-0008Mh-00@spohr.debian.org> User-Agent: Mutt/1.5.9i Delivered-To: 326192-done@bugs.debian.org X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 (1.212-2003-09-23-exp) on spohr.debian.org X-Spam-Level: X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no version=2.60-bugs.debian.org_2005_01_02 Version: 3.70 tagging for the BTS version tracking. Greetings Marc -- ----------------------------------------------------------------------------- Marc Haber | "I don''t trust Computers. They | Mailadresse im Header Mannheim, Germany | lose things." Winona Ryder | Fon: *49 621 72739834 Nordisch by Nature | How to make an American Quilt | Fax: *49 621 72739835